Open
Conversation
Collaborator
Yazhou-Z
commented
Mar 2, 2023
- Implement the CELO method to the sparsecoding.inference
- Add a test for the CELO method.
- Add a jupyter notebook that demonstrates the method working on bars example.
cshewmake2
requested changes
Mar 2, 2023
Contributor
There was a problem hiding this comment.
Hi Yazhou!
Awesome job submitting your method and supporting files to the repo! I've made a few comments for correction to address.
The main thing to fix is the update method for CEL0. The update rule is similar to LCA, but it's not quite the same. I've detailed the difference in the inference.py file notes.
I don't know if this is related, but when I run the inference method in the bars notebook example, sometimes coefficients are right, but other times the baseline deviates significantly from zero. I suspect this will be fixed by fixing the CEL0 update rule. I've included an example of the problem below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
