Open
Conversation
9q9q
requested changes
Jun 17, 2022
Collaborator
9q9q
left a comment
There was a problem hiding this comment.
thanks Alvin! just aesthetic nits about the vanilla tutorial notebook:
- for some reason the plots/figures all look undertrained, could you return them to original condition? everything should look the same as before if you run it without changing params.
- not sure why this is happening, but the tutorial Field images have different
vranges than they should. i set it so the contrast is higher: https://github.com/rctn/sparsecoding/blob/main/tutorials/vanilla/src/utils.py#L64, but it doesn't look like that is being applied to notebook in this branch - could you fix the warnings? if it's a jupyter version/package issue i can do it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.