Skip to content

Conversation

@rbx
Copy link
Owner

@rbx rbx commented Apr 9, 2025

Add a processing script with a single shm segment.

@rbx
Copy link
Owner Author

rbx commented Apr 9, 2025

@pearbot review

@pearbot
Copy link

pearbot bot commented Apr 9, 2025

The Pull Request introduces a new processing script and modifies the build configuration to include it. Here's the concise feedback on potential issues:

  1. Duplicate --id in Processors: Both PROCESSOR1 and PROCESSOR2 have the same ID (processor1). This duplication can cause conflicts, as unique IDs are typically required for distinct processes.

Recommendations:

  • Assign a unique ID to each processor (e.g., processor1 and processor2).
  • Consider adding error handling in case any application fails to start.
  • Optionally include checks or instructions for the FAIRMQ_PATH setup.

Fixing the duplicate IDs is crucial for correct functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants