Skip to content

Move not (host or instance) check before (host and instance) check #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zyzip wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move not (host or instance) check before (host and instance) check #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pysnow/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ def __init__(
session=None,
):

if not (host or instance):
raise InvalidUsage("You must supply either 'instance' or 'host'")

if (host and instance) is not None:
raise InvalidUsage(
"Arguments 'instance' and 'host' are mutually exclusive, you cannot use both."
Expand All @@ -65,9 +68,6 @@ def __init__(
else:
raise InvalidUsage("Argument 'raise_on_empty' must be of type bool")

if not (host or instance):
raise InvalidUsage("You must supply either 'instance' or 'host'")

if not isinstance(self, pysnow.OAuthClient):
if not (user and password) and not session:
raise InvalidUsage(
Expand Down