Enable using ifscripts for alias resources; allow setting ifcfg resources to absent (remove file)#133
Open
esalberg wants to merge 1 commit intorazorsedge:developfrom
Open
Enable using ifscripts for alias resources; allow setting ifcfg resources to absent (remove file)#133esalberg wants to merge 1 commit intorazorsedge:developfrom
esalberg wants to merge 1 commit intorazorsedge:developfrom
Conversation
…rces to absent (remove file)
Contributor
Author
|
I have a branch that combines both restarts and ifscripts into one, if that would be helpful. I didn't know if you'd want the functionality split into two PRs. |
|
I had to replace the following code to make it work on my setup. in centos7 the ":" is replaced by "_" in interfaces fact. |
|
In my case puppet doesn't replace ':' by '_' in $::interfaces. So should be safe have both conditions like: --- a/modules/network/manifests/init.pp if $ifscripts {
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a parameter to allow using the ifup / ifdown scripts for alias resources only (less disruptive than a full network restart).
Allow removal of ifcfg file for aliases when ensure is set to absent.