fix: Boolean correction in doc by ankitdas13 · Pull Request #298 · razorpay/razorpay-python

ankitdas13 · 2025-06-27T06:10:43Z

Note :- Please follow the below points while attaching test cases document link below:

- If label `Tested` is added then test cases document URL is mandatory.

- Link added should be a valid URL and accessible throughout the org.

- If the branch name contains hotfix / revert by default the BVT workflow check will pass.

Test Case Document URL
Please paste test case document link here....

vinitajag · 2025-06-27T06:20:41Z

documents/payment.md

+    	"java_enabled": false,
+    	"javascript_enabled": false,


replace with True/False

vinitajag · 2025-06-27T06:21:05Z

documents/registerEmandate.md

 | email        | string      | Email of the customer                       |
 | contact      | string      | Contact number of the customer              |
-| fail_existing | string | If a customer with the same details already exists, the request throws an exception by default. Possible value is `0` or `1`|
+| fail_existing | string | If a customer with the same details already exists, the request throws an exception by default. Possible value is `True` or `False`|


Possible value is True or False.

for highlight, added True/False in ``

vinitajag · 2025-06-27T06:21:21Z

documents/registerEmandate.md

@@ -148,8 +148,8 @@ client.registration_link.create({
 | subscription_registration   | object  | All keys listed [here](https://razorpay.com/docs/api/recurring-payments/emandate/auto-debit/#12-using-a-registration-link) are supported  |
 | receipt      | string  | Your system order reference id.  |
 | payment_capture* |  boolean  | Indicates whether payment status should be changed to `captured` automatically or not. Possible values: true - Payments are captured automatically. false - Payments are not captured automatically.|


vinitajag · 2025-06-27T06:21:58Z

documents/subscription.md

+  "remaining_count":5,
+  "start_at":1496000432,
+  "schedule_change_at":"now",
+  "customer_notify": true


updated To True

vinitajag · 2025-06-27T06:23:00Z

documents/upi.md

 | email        | string      | Email of the customer                       |
 | contact      | string      | Contact number of the customer              |
-| fail_existing | string | If a customer with the same details already exists, the request throws an exception by default. Possible value is `0` or `1`|x`
+| fail_existing | string | If a customer with the same details already exists, the request throws an exception by default. Possible value is `True` or `False`|x`


the extra x' should be removed?

vinitajag · 2025-06-27T06:29:57Z

pls consider this also: https://github.com/razorpay/razorpay-python/blob/master/documents/paymentLink.md#customize-payment-methods. Here UPI, Netbanking are all boolean values.

vinitajag · 2025-06-27T06:55:24Z

here as well, recurring parameter here is boolean:

razorpay-python/documents/card.md

Line 271 in 283773b

## Create a recurring payment

need to make the same changes across payment methods: upi, emandate...

vinitajag · 2025-06-27T08:05:29Z

razorpay-python/documents/upi.md

Line 107 in 283773b

### Create registration link

- "sms_notify" and "email_notify" are boolean

vinitajag · 2025-06-27T08:12:45Z

https://github.com/razorpay/razorpay-python/blob/283773b4aba0a4a423f1a80966188186c6272c6f/documents/paymentLink.md?plain=1#L780C7-L781C18 - Here email and contact are boolean

vinitajag · 2025-06-27T08:15:39Z

razorpay-python/documents/payment.md

Line 501 in 283773b

"save": 1,

- here save is a boolean value

vinitajag · 2025-06-27T08:39:02Z

razorpay-python/documents/items.md

Line 145 in 283773b

| active | boolean | Possible values is `0` or `1` |

- here active is a boolean value.

vinitajag · 2025-06-27T08:46:12Z

razorpay-python/documents/subscription.md

Line 270 in 283773b

    
           | cancel_at_cycle_end  | boolean | Possible values:<br>0 (default): Cancel the subscription immediately. <br> 1: Cancel the subscription at the end of the current billing cycle.  |

- cancel_at_cycle_end is a boolean value. need to replace 1/0 with True/False in the description table

vinitajag · 2025-06-27T08:47:07Z

razorpay-python/documents/subscription.md

Line 8 in 283773b

"customer_notify": 1,

- customer_notify is a boolean value.

vinitajag · 2025-06-27T08:49:09Z

razorpay-python/documents/card.md

Line 584 in 283773b

    
           | tokenised  | string | Determines if the card is saved as a token. Possible value is `true` or `false` |

- tokenised is a boolean param. need to change data type in description table

ankitdas13 · 2025-06-30T08:17:03Z

razorpay-python/documents/items.md

Line 145 in 283773b

| active | boolean | Possible values is `0` or `1` |

here active is a boolean value.

item only support 1/0 (tested)

vinitajag

approved

fix: Boolean correction in doc

ade89d4

vinitajag reviewed Jun 27, 2025

View reviewed changes

ankitdas13 added 2 commits June 30, 2025 13:47

made correction according to comments

20d38a4

fail existing value correction

9fcb48c

vinitajag approved these changes Jul 7, 2025

View reviewed changes

ankitdas13 added the TestingNotRequired TestingNotRequired label for BVT label Jul 7, 2025

ankitdas13 merged commit ed87afb into master Jul 7, 2025
10 of 11 checks passed

Conversation

ankitdas13 commented Jun 27, 2025

Note :- Please follow the below points while attaching test cases document link below:

- If label Tested is added then test cases document URL is mandatory.

- Link added should be a valid URL and accessible throughout the org.

- If the branch name contains hotfix / revert by default the BVT workflow check will pass.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vinitajag commented Jun 27, 2025

Uh oh!

vinitajag commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinitajag commented Jun 27, 2025

Uh oh!

vinitajag commented Jun 27, 2025

Uh oh!

vinitajag commented Jun 27, 2025

Uh oh!

vinitajag commented Jun 27, 2025

Uh oh!

vinitajag commented Jun 27, 2025

Uh oh!

vinitajag commented Jun 27, 2025

Uh oh!

vinitajag commented Jun 27, 2025

Uh oh!

ankitdas13 commented Jun 30, 2025

Uh oh!

vinitajag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

- If label `Tested` is added then test cases document URL is mandatory.

vinitajag commented Jun 27, 2025 •

edited

Loading