Fix signature verification when using OAuth token authentication#389
Open
haris-5hah wants to merge 3 commits intorazorpay:masterfrom
Open
Fix signature verification when using OAuth token authentication#389haris-5hah wants to merge 3 commits intorazorpay:masterfrom
haris-5hah wants to merge 3 commits intorazorpay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix signature verification when using OAuth token authentication
Description
This PR addresses an issue with signature verification when the API is instantiated with an OAuth token instead of a key/secret pair. The current implementation fails because it relies on
Api::getSecret()which returns null when using OAuth token authentication.Changes
verifyPaymentSignatureto accept a secret in the attributes when using OAuth tokensverifyWebhookSignatureto make the secret parameter optional and handle OAuth token scenariosTesting
Tested signature verification with both standard key/secret auth and OAuth token auth.