Skip to content

php sdk update#25

Open
jampulanaveen wants to merge 2 commits intomasterfrom
php_sdk_update
Open

php sdk update#25
jampulanaveen wants to merge 2 commits intomasterfrom
php_sdk_update

Conversation

@jampulanaveen
Copy link
Copy Markdown

No description provided.

if (isset($options['verify'])) {
if ($options['verify'] === false) {
curl_setopt($this->handle, CURLOPT_SSL_VERIFYHOST, 0);
curl_setopt($this->handle, CURLOPT_SSL_VERIFYPEER, 0);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSL verification is disabled but should not be (currently CURLOPT_SSL_VERIFYPEER= 0)

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

Please address this comment before merging this pull request.
(php.lang.security.curl-ssl-verifypeer-off.curl-ssl-verifypeer-off in PAYMENT_EXP_PHP_BLOCK)

Copy link
Copy Markdown

@ramth05 ramth05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants