This repository was archived by the owner on Nov 14, 2023. It is now read-only.
forked from hypertrace/hypertrace-ui
-
Notifications
You must be signed in to change notification settings - Fork 2
refactor: replace onReady with data property in metric widget for Explorer #113
Open
cseas
wants to merge
6
commits into
rzp_main
Choose a base branch
from
repro-metric-refactor
base: rzp_main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## rzp_main #113 +/- ##
=============================================
- Coverage 81.70% 58.04% -23.66%
=============================================
Files 933 933
Lines 20133 20131 -2
Branches 2740 2741 +1
=============================================
- Hits 16449 11686 -4763
- Misses 3530 8061 +4531
- Partials 154 384 +230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment has been minimized.
This comment has been minimized.
70a1257 to
8cc14b5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a refactor of the changes added in #107 and doesn't change any functionality in the application. Check deleted comment in the code for context and motivation behind the refactor.
Testing
Todo
Checklist: