Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

Conversation

@amandal97
Copy link

@amandal97 amandal97 commented Nov 29, 2022

Description

JIRA

Provided Edit Access to All Dashboards in Custom Dashboards Section.
Screenshot:
Screenshot 2022-11-29 at 3 56 11 PM

Testing

Tested on local

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@amandal97 amandal97 added the ReadyForReview ReadyForReview label Nov 29, 2022
@amandal97 amandal97 self-assigned this Nov 29, 2022
Copy link

@cseas cseas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge after testing in test environment once backend is ready.
cc: @13shivam @Sunn-y-Arora

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #105 (118bd10) into rzp_main (ef81dec) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           rzp_main     #105   +/-   ##
=========================================
  Coverage     81.90%   81.91%           
=========================================
  Files           931      931           
  Lines         20014    20011    -3     
  Branches       2708     2707    -1     
=========================================
- Hits          16393    16392    -1     
+ Misses         3473     3472    -1     
+ Partials        148      147    -1     
Impacted Files Coverage Δ
...hboard-detail/custom-dashboard-detail.component.ts 8.42% <0.00%> (+0.17%) ⬆️
...ashboard-panel/custom-dashboard-panel.component.ts 25.58% <ø> (-1.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions

This comment has been minimized.

Copy link

@jaywalker21 jaywalker21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions
Copy link

Unit Test Results

       4 files  ±0     302 suites  ±0   24m 37s ⏱️ -32s
1 084 tests ±0  1 084 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 092 runs  ±0  1 092 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 118bd10. ± Comparison against base commit ef81dec.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ReadyForReview ReadyForReview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants