This repository was archived by the owner on Nov 14, 2023. It is now read-only.
forked from hypertrace/hypertrace-ui
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: custom dashboard edit access #105
Open
amandal97
wants to merge
2
commits into
rzp_main
Choose a base branch
from
feat/custom-dashboard-edit
base: rzp_main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cseas
reviewed
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's merge after testing in test environment once backend is ready.
cc: @13shivam @Sunn-y-Arora
Codecov Report
@@ Coverage Diff @@
## rzp_main #105 +/- ##
=========================================
Coverage 81.90% 81.91%
=========================================
Files 931 931
Lines 20014 20011 -3
Branches 2708 2707 -1
=========================================
- Hits 16393 16392 -1
+ Misses 3473 3472 -1
+ Partials 148 147 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment has been minimized.
This comment has been minimized.
jaywalker21
approved these changes
Nov 29, 2022
jaywalker21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JIRA
Provided Edit Access to All Dashboards in Custom Dashboards Section.

Screenshot:
Testing
Tested on local
Checklist: