Feat: Added Icon component | Updated Button and Link component to support Icons#3084
Merged
kashishbehl merged 39 commits intofeat/divider-componentfrom Feb 11, 2026
Merged
Feat: Added Icon component | Updated Button and Link component to support Icons#3084kashishbehl merged 39 commits intofeat/divider-componentfrom
kashishbehl merged 39 commits intofeat/divider-componentfrom
Conversation
…Svelte Migration (#3020) * Added Link Component to Svelte | Cursor Rules for Effecient React to Svelte Migration * Added Link Component to Svelte | Cursor Rules for Effecient React to Svelte Migration * PR comments resolved * Added Base Text Component | Migrated styles to use css classes | updated link to use BaseText (#3030) * Added Base Text Component | Migrated styles to use css classes | updated link to use BaseText * Added Heading | Code | Text component | Refactored to use default css styling and create classes (#3033) * Added Heading | Code | Text component | Refactored to use default css styling and create classes * CSS STyling migration | Migrated all css logic to blade-core (#3036) * CSS STyling migration | Migrated all css logic to blade-core * PR comments resolved * Added Button.Svelte (#3042) * Added Button.Svelte * Added PostCSS support | Added Loader component for Button (#3043) * Added PostCSS support | Added Loader component for Button * Added amount component (#3048)
* Added Link Component to Svelte | Cursor Rules for Effecient React to Svelte Migration * Added Link Component to Svelte | Cursor Rules for Effecient React to Svelte Migration * PR comments resolved * Added Base Text Component | Migrated styles to use css classes | updated link to use BaseText * Added Heading | Code | Text component | Refactored to use default css styling and create classes * CSS STyling migration | Migrated all css logic to blade-core * PR comments resolved * Added Button.Svelte * Added PostCSS support | Added Loader component for Button * Added amount component * Added storybook implementation * Added storybook implementation * Added storybook implementation * Added storybook implementation * Added storybook implementation * Added storybook implementation * Fixed build issues * Fixed build issues * Fixed build issues * Fixed build issues * Fixed storybook workflow * Storybook playground fixes * Storybook playground fixes * Fixed fonts * Pr comments resolved * Reverting blade-core from blade-react (#3059) * Reverting blade-core from blade-react * Reverting blade-core from blade-react * Upgraded to node 20 * Upgraded to node 20 * Migrated vite to rollup (#3060) * Migrated vite to rollup * Updated publish workflow * PR comments resolved * PR comments resolved * Resolved all design review comments (#3062) * Resolved all design review comments * Resolved all design review comments * Added Readme and installation docs * Updated docs
This reverts commit 2e83c59.
This reverts commit 4623726.
* Fixed validate workflow * Fixed validate workflow * Fixed validate workflow * Fixed typescript and svelte check step * Fixed typescript and svelte check step * Fixed validate workflow
|
Contributor
|
❌ PR title doesn't follow Conventional Commits specification. Details: |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit efbcd48:
|
Collaborator
🛡️ Coverage ReportSummaryFull Coverage Details |
Base automatically changed from
fix/react-dependencies-blade-core
to
feat/svelte-impl
January 14, 2026 09:33
kashishbehl
requested review from
anuraghazra,
chaitanyadeorukhkar,
kamleshchandnani,
ravikumar-rajagopalan,
saurabhdaware,
swapnil-kr1 and
tewarig
as code owners
saurabhdaware
previously approved these changes
Jan 23, 2026
Member
There was a problem hiding this comment.
for react icons, we have a script to add these icons. can you see if we can add similar script here as well? then we can just run that script and add all icons in one go
Member
There was a problem hiding this comment.
can you check React's stories once. We have a dropdown to select icon there and change its position. can you add these controls here as well?
saurabhdaware
approved these changes
Feb 11, 2026
Member
saurabhdaware
left a comment
saurabhdaware
left a comment
There was a problem hiding this comment.
Looks good to me. Can you fix the failing checks on both PRs before merging
kashishbehl
added a commit
that referenced
this pull request
Feb 11, 2026
* Added Divider component * Added release notes * PR comments resolved * PR comments resolved * Updated version type * Feat: Added Icon component | Updated Button and Link component to support Icons (#3084) * feat: add svelte directory structure * feat: add blade-svelte package * feat: add theme switcher * feat: add global styles * Added Link Component to Svelte | Cursor Rules for Effecient React to Svelte Migration (#3020) * Added Link Component to Svelte | Cursor Rules for Effecient React to Svelte Migration * Added Link Component to Svelte | Cursor Rules for Effecient React to Svelte Migration * PR comments resolved * Added Base Text Component | Migrated styles to use css classes | updated link to use BaseText (#3030) * Added Base Text Component | Migrated styles to use css classes | updated link to use BaseText * Added Heading | Code | Text component | Refactored to use default css styling and create classes (#3033) * Added Heading | Code | Text component | Refactored to use default css styling and create classes * CSS STyling migration | Migrated all css logic to blade-core (#3036) * CSS STyling migration | Migrated all css logic to blade-core * PR comments resolved * Added Button.Svelte (#3042) * Added Button.Svelte * Added PostCSS support | Added Loader component for Button (#3043) * Added PostCSS support | Added Loader component for Button * Added amount component (#3048) * Feat/svelte storybook (#3055) * Added Link Component to Svelte | Cursor Rules for Effecient React to Svelte Migration * Added Link Component to Svelte | Cursor Rules for Effecient React to Svelte Migration * PR comments resolved * Added Base Text Component | Migrated styles to use css classes | updated link to use BaseText * Added Heading | Code | Text component | Refactored to use default css styling and create classes * CSS STyling migration | Migrated all css logic to blade-core * PR comments resolved * Added Button.Svelte * Added PostCSS support | Added Loader component for Button * Added amount component * Added storybook implementation * Added storybook implementation * Added storybook implementation * Added storybook implementation * Added storybook implementation * Added storybook implementation * Fixed build issues * Fixed build issues * Fixed build issues * Fixed build issues * Fixed storybook workflow * Storybook playground fixes * Storybook playground fixes * Fixed fonts * Pr comments resolved * Reverting blade-core from blade-react (#3059) * Reverting blade-core from blade-react * Reverting blade-core from blade-react * Upgraded to node 20 * Upgraded to node 20 * Migrated vite to rollup (#3060) * Migrated vite to rollup * Updated publish workflow * PR comments resolved * PR comments resolved * Resolved all design review comments (#3062) * Resolved all design review comments * Resolved all design review comments * Added Readme and installation docs * Updated docs * fixed workflows * fixing failing workflows * fixing failing workflows * Fixed failing FTs * Fixing failing UTS * reverting yarn.lock * reverting yarn.lock * Revert "reverting yarn.lock" This reverts commit 2e83c59. * Revert "reverting yarn.lock" This reverts commit 4623726. * Fixing failing UTS * Fixed failing tests * Fixed failing tests * lint failure * lint failure * Fixed validate workflow (#3072) * Fixed validate workflow * Fixed validate workflow * Fixed validate workflow * Fixed typescript and svelte check step * Fixed typescript and svelte check step * Fixed validate workflow * Fix: Remove React and React Native dependency from blade-core * Lint issues fiex * Lint issues fiex * Lint issues fiex * Lint issues fiex * Lint issues fiex * Lint issues fiex * Lint issues fiex * Fixed alignment issues * Feat: Added Icon component | Updated Button and Link component to support Icons * merged latest master * Removed unused changes * PR comments resolved * Added icon in Badge component * fixed svelte check failure --------- Co-authored-by: saurabhdaware <saurabh.daware@razorpay.com> --------- Co-authored-by: saurabhdaware <saurabh.daware@razorpay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR contains the changes to support
Description
Changes
Additional Information
Component Checklist