Skip to content
This repository was archived by the owner on Apr 10, 2026. It is now read-only.

Allow remoteType to be overridden at the Version level#1230

Draft
carrolp wants to merge 3 commits intomasterfrom
version-remotetype
Draft

Allow remoteType to be overridden at the Version level#1230
carrolp wants to merge 3 commits intomasterfrom
version-remotetype

Conversation

@carrolp
Copy link
Copy Markdown
Contributor

@carrolp carrolp commented Oct 12, 2022

If it becomes desirable to allow having a mix of multiple remoteTypes (e.g. both github and gitlab) Versions under the same Channel, this change will allow it:

  • remoteType can still be set on the Channel, but becomes optional
  • remoteType can be set on each Version
  • The remoteType from the Version is used if set, else the one from the Channel if set. Neither set, no remote type is passed to the cluster (which will probably result in an error as it won't know how to handle it)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant