Fix SetWindowSize bug on Retina display#5706
Open
JoeStrout wants to merge 1 commit intoraysan5:masterfrom
Open
Fix SetWindowSize bug on Retina display#5706JoeStrout wants to merge 1 commit intoraysan5:masterfrom
JoeStrout wants to merge 1 commit intoraysan5:masterfrom
Conversation
resizing the window on a retina display.
Contributor
Author
|
NOTE: the actual fix was coded by Claude Opus 4.6. |
Owner
|
@JoeStrout Note that GLFW manages multiple platforms, did you test those changes on Windows, Linux X11, Linux Wayland and HTML5? Did you test those changes on multiple monitors configuration with different DPIs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the following issue (on MacOS):
The issue seemed to be that SetWindowSize updated CORE.Window.screen but not CORE.Window.render (and moving the window to another display caused the render to update, thus "fixing" the issue).
This PR adds code to update the render right away. Now my resized windows correctly show their rendering, even on a retina display. Tested both with and without the FLAG_WINDOW_HIDPI flag.