Skip to content

Fix useFetch paginated URL factory errors #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mralonsocorona wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix useFetch paginated URL factory errors #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/useFetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,16 @@ export function useFetch<V = unknown, U = undefined, T extends unknown[] = unkno
const mapResultRef = useLatest(mapResult || defaultMapping);
const urlRef = useRef<RequestInfo | PaginatedRequestInfo>(null);
const firstPageUrlRef = useRef<RequestInfo | undefined>(null);
const firstPageUrl = typeof url === "function" ? url({ page: 0 }) : undefined;
const isPaginated = typeof url === "function";
let firstPageUrl: RequestInfo | undefined;

if (isPaginated) {
try {
firstPageUrl = url({ page: 0 });
} catch {
// Defer URL factory errors to the paginated fetcher so usePromise can expose them through its error state.
}
}
/**
* When paginating, `url` is a `PaginatedRequestInfo`, so we only want to update the ref when the `firstPageUrl` changes.
* When not paginating, `url` is a `RequestInfo`, so we want to update the ref whenever `url` changes.
Expand Down Expand Up @@ -174,11 +183,11 @@ export function useFetch<V = unknown, U = undefined, T extends unknown[] = unkno
);

const promise = useMemo(() => {
if (firstPageUrlRef.current) {
if (isPaginated) {
return paginatedFn;
}
return fn;
}, [firstPageUrlRef, fn, paginatedFn]);
}, [isPaginated, fn, paginatedFn]);

// @ts-expect-error lastItem can't be inferred properly
return useCachedPromise(promise, [urlRef.current as PaginatedRequestInfo, fetchOptions], {
Expand Down