[train][tests] Reduce test_worker_group flake#61536
Open
TimothySeah wants to merge 1 commit intoray-project:masterfrom
Open
[train][tests] Reduce test_worker_group flake#61536TimothySeah wants to merge 1 commit intoray-project:masterfrom
TimothySeah wants to merge 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: Timothy Seah <tseah@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a flaky test, test_zombie_actor_termination, which was failing due to a WorkerGroupStartupTimeoutError. The root cause was identified as the mock_runtime_context fixture's DummyActor consuming a CPU resource by default, leaving insufficient resources for the test's worker group. The fix correctly specifies num_cpus=0 for this dummy actor, ensuring it doesn't consume cluster resources. This change is logical, safe, and should resolve the flakiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_zombie_actor_terminationhas been failing flakily withThis could be due to
mock_runtime_contextunintentionally taking up ray cluster resources.Testing
I was unable to reproduce the issue locally but this change should be safe.