[Data] Actor Pool get correct logical resource usage#61528
Open
machichima wants to merge 3 commits intoray-project:masterfrom
Open
[Data] Actor Pool get correct logical resource usage#61528machichima wants to merge 3 commits intoray-project:masterfrom
machichima wants to merge 3 commits intoray-project:masterfrom
Conversation
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
ray-gardener
bot
added
data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ActorPoolMapOperatorreport logical resource usage based on statically-definedray_remote_args. Ifray_remote_args_fnis defined, then the operator can launch tasks with more logical resources than the statically definedray_remote_args. This leads to resource manager undercounting logical resource usage. We should record the actual resources we used.In this PR, we did the following changes:
actor_pool_map_operator.py:_ray_remote_args_fn_ActorResourceUsageTrackerto keep track of resource usage for total and pending to provide O(1) resource usage lookuptest_executor_resource_management.py:current_logical_usagereflects dynamic resources fromray_remote_args_fnforActorPoolMapOperatortest_actor_pool_map_operator.py:Related issues
Closes #61395
Additional information