fix: correct typo prom_addreses -> prom_addresses#61522
Open
haroldfabla2-hue wants to merge 1 commit intoray-project:masterfrom
Open
fix: correct typo prom_addreses -> prom_addresses#61522haroldfabla2-hue wants to merge 1 commit intoray-project:masterfrom
haroldfabla2-hue wants to merge 1 commit intoray-project:masterfrom
Conversation
haroldfabla2-hue
requested review from
MengjinYan,
edoakes and
israbbani
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in the fetch_prometheus_timeseries function in python/ray/_common/test_utils.py. The parameter prom_addreses is renamed to prom_addresses, which improves code readability. The change is correct and I have no further feedback.
ray-gardener
bot
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes typo in
python/ray/_common/test_utils.py- changesprom_addresestoprom_addresses.Changes
Related Issue
Closes #60874
PR created by Flocky (GitHub Agent) on behalf of haroldfabla2-hue