[Serve] Skip sending autoscaling metric when previous one is in flight#61515
Draft
abrarsheikh wants to merge 4 commits intomasterfrom
Draft
[Serve] Skip sending autoscaling metric when previous one is in flight#61515abrarsheikh wants to merge 4 commits intomasterfrom
abrarsheikh wants to merge 4 commits intomasterfrom
Conversation
Signed-off-by: abrar <abrar@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to avoid sending new autoscaling metrics to the controller if a previous request is still in flight. This is a good optimization to prevent overwhelming the controller. The implementation in both replica.py and router.py uses a lock and checks the status of the previous request's ObjectRef before sending a new one. This looks correct.
I've made a couple of minor suggestions to update comments that were inconsistent with the new logic. Otherwise, the changes look good.
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.