-
Notifications
You must be signed in to change notification settings - Fork 7.5k
[core] upgrade grpc to v1.58.0 #61499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5119b4f
3622f49
7924c54
6722168
d2aedf6
e0a18b3
baeaed7
5d88dc4
4502c0e
68414cc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -139,10 +139,10 @@ class GcsHealthCheckManagerTest : public ::testing::Test { | |
| } | ||
|
|
||
| instrumented_io_context io_service; | ||
| std::shared_ptr<gcs::GcsHealthCheckManager> health_check; | ||
| std::unordered_map<NodeID, std::shared_ptr<rpc::GrpcServer>> servers; | ||
| std::unordered_set<NodeID> dead_nodes; | ||
| ray::observability::FakeHistogram fake_health_check_rpc_latency_ms_histogram_; | ||
| std::shared_ptr<gcs::GcsHealthCheckManager> health_check; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This fix tsan failure. The Async health-check callbacks may still run during teardown and record metric latency. Previously, FakeHistogram could be destroyed before health_check, causing races and failures. |
||
| const int64_t initial_delay_ms = 100; | ||
| const int64_t timeout_ms = 10; | ||
| const int64_t period_ms = 10; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| diff -u BUILD | ||
| --- BUILD | ||
| +++ BUILD | ||
| @@ -30,7 +30,3 @@ | ||
| package( | ||
| - default_visibility = ["//visibility:public"], | ||
| - features = [ | ||
| - "layering_check", | ||
| - "-parse_headers", | ||
| - ], | ||
| + default_visibility = ["//visibility:public"], | ||
| ) | ||
| diff -u src/core/BUILD | ||
| --- src/core/BUILD | ||
| +++ src/core/BUILD | ||
| @@ -25,6 +25,3 @@ | ||
| package( | ||
| default_visibility = ["//:__subpackages__"], | ||
| - features = [ | ||
| - "layering_check", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suppress the undeclared inclusion flood in the build logs. This won't affect runtime behavior. See #61623 for more details. |
||
| - ], | ||
| ) | ||
| diff -u src/cpp/ext/gsm/BUILD | ||
| --- src/cpp/ext/gsm/BUILD | ||
| +++ src/cpp/ext/gsm/BUILD | ||
| @@ -24,8 +24,5 @@ | ||
| package( | ||
| default_visibility = ["//visibility:public"], | ||
| - features = [ | ||
| - "layering_check", | ||
| - ], | ||
| ) | ||
|
|
||
| grpc_cc_library( | ||
| diff -u src/cpp/ext/gcp/BUILD | ||
| --- src/cpp/ext/gcp/BUILD | ||
| +++ src/cpp/ext/gcp/BUILD | ||
| @@ -24,8 +24,5 @@ | ||
| package( | ||
| default_visibility = ["//visibility:public"], | ||
| - features = [ | ||
| - "layering_check", | ||
| - ], | ||
| ) | ||
|
|
||
| grpc_cc_library( | ||
| diff -u src/cpp/ext/otel/BUILD | ||
| --- src/cpp/ext/otel/BUILD | ||
| +++ src/cpp/ext/otel/BUILD | ||
| @@ -24,8 +24,5 @@ | ||
| package( | ||
| default_visibility = ["//visibility:public"], | ||
| - features = [ | ||
| - "layering_check", | ||
| - ], | ||
| ) | ||
|
|
||
| grpc_cc_library( | ||
| diff -u test/core/transport/binder/end2end/fuzzers/BUILD | ||
| --- test/core/transport/binder/end2end/fuzzers/BUILD | ||
| +++ test/core/transport/binder/end2end/fuzzers/BUILD | ||
| @@ -17,7 +17,4 @@ | ||
|
|
||
| grpc_package( | ||
| name = "test/core/transport/binder/end2end/fuzzers", | ||
| - features = [ | ||
| - "layering_check", | ||
| - ], | ||
| ) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| diff --git src/core/lib/promise/pipe.h b/src/core/lib/promise/pipe.h | ||
| --- src/core/lib/promise/pipe.h | ||
| +++ src/core/lib/promise/pipe.h | ||
| @@ -63,9 +63,9 @@ | ||
| template <typename T> | ||
| class NextResult final { | ||
| public: | ||
| - NextResult() : center_(nullptr) {} | ||
| + NextResult() : center_(nullptr), cancelled_(true) {} | ||
| explicit NextResult(RefCountedPtr<pipe_detail::Center<T>> center) | ||
| - : center_(std::move(center)) { | ||
| + : center_(std::move(center)), cancelled_(false) { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This makes the ubsan check on the grpc library pass. |
||
| GPR_ASSERT(center_ != nullptr); | ||
| } | ||
| explicit NextResult(bool cancelled) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment referencing bug fix in Bazel 7.3.0 bazelbuild/bazel#21592, as well as llvm/llvm-project@5bba176 LLVM using the same workaround in their BUILD files (llvm/llvm-project@5bba176)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.