Skip to content

[core] upgrade grpc to v1.76.0#61498

Draft
rueian wants to merge 2 commits intoray-project:masterfrom
rueian:upgrade-grpc-1760
Draft

[core] upgrade grpc to v1.76.0#61498
rueian wants to merge 2 commits intoray-project:masterfrom
rueian:upgrade-grpc-1760

Conversation

@rueian
Copy link
Contributor

@rueian rueian commented Mar 4, 2026

Thank you for contributing to Ray! 🚀
Please review the Ray Contribution Guide before opening a pull request.

⚠️ Remove these instructions before submitting your PR.

💡 Tip: Mark as draft if you want early feedback, or ready for review when it's complete.

Description

Briefly describe what this PR accomplishes and why it's needed.

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades gRPC to v1.76.0 and updates related dependencies like protobuf and boringssl. The security review noted that no specific code changes were provided for analysis, thus a detailed security review could not be performed. The code review identified areas for improvement within the patch file to enhance code clarity and correctness, specifically regarding the adaptation of the configurable gRPC thread count for the new gRPC version.

#ifdef GPR_CPU_LINUX

+#include <charconv>
+#include <cstdlib>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The code uses std::strlen on line 21, which requires the <cstring> header. This header is not included in the patch, which may lead to compilation errors. Please add #include <cstring> to ensure std::strlen is available.

#include <cstdlib>
#include <cstring>

Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
@rueian rueian force-pushed the upgrade-grpc-1760 branch from 316f35d to 4c60259 Compare March 4, 2026 21:28
@rueian rueian added the go add ONLY when ready to merge, run all tests label Mar 4, 2026
Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ray fails to serialize self-reference objects

1 participant