Generate LLMs text during site build#101
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughIntegrates PHP llms-full generation into the primary Jekyll build and local serve, removes llms-full tracking from the documentation-update workflow (now tracking only English/Japanese single-page files), adds llms-full.txt to .gitignore, updates README examples, and hardens the PHP generator's I/O and regex error checks. ChangesLLM Documentation Generation and Workflow Consolidation
Sequence DiagramsequenceDiagram
participant GH_Actions as GitHub Actions (jekyll.yml)
participant SetupPHP as shivammathur/setup-php
participant PHP_Generator as php bin/generate_llms_full.php
participant Jekyll as bundle exec jekyll build
participant Local_Serve as bin/serve_local.sh
participant Deploy as deploy job (pages)
GH_Actions->>SetupPHP: setup php 8.3
GH_Actions->>PHP_Generator: run php bin/generate_llms_full.php (build step)
Local_Serve->>PHP_Generator: run php bin/generate_llms_full.php (pre-build)
PHP_Generator->>Jekyll: generate llms-full content for site build
Jekyll->>Deploy: produce site artifacts
Deploy->>Deploy: pages: write / id-token: write (scoped to deploy job)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/update-documentation.yml (1)
46-50: ⚡ Quick winDrop
llms-full.txtregeneration from this workflow.This job now commits only single-page docs, so regenerating
llms-full.txthere is redundant and increases failure surface.Proposed simplification
- name: Regenerate documentation run: | - echo "Regenerating llms-full.txt..." - php bin/generate_llms_full.php - echo "Regenerating single-page documentation..." ruby bin/merge_md_files.rb(After this, you can also remove the PHP setup step from this workflow.)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/update-documentation.yml around lines 46 - 50, Remove the "Regenerate documentation" step that echoes and runs php bin/generate_llms_full.php from the workflow (the step with name "Regenerate documentation") because llms-full.txt regeneration is redundant; delete the two lines that run the echo and the php command and remove the whole step block, and then also remove the PHP setup step (the job/step that installs PHP) since it will no longer be needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/jekyll.yml:
- Line 38: The workflow currently uses tag-pinned actions (e.g.,
shivammathur/setup-php@v2, actions/checkout@v4, ruby/setup-ruby@v1,
actions/configure-pages@v5, actions/upload-pages-artifact@v3,
actions/deploy-pages@v4); replace each tag reference with the corresponding
commit SHA for that action (pin to a specific commit) to harden the supply
chain, updating the `uses:` lines to the SHA-pinned form for
shivammathur/setup-php, actions/checkout, ruby/setup-ruby,
actions/configure-pages, actions/upload-pages-artifact and actions/deploy-pages.
In `@bin/serve_local.sh`:
- Around line 9-10: The script runs php bin/generate_llms_full.php before Jekyll
but doesn't fail fast; update bin/serve_local.sh to abort if php
bin/generate_llms_full.php fails by enabling strict exit-on-error (e.g., set -e
at top) or chaining the commands so bundle exec jekyll build/serve only runs
when php bin/generate_llms_full.php succeeds; ensure references to the commands
php bin/generate_llms_full.php and bundle exec jekyll build (and/or bundle exec
jekyll serve) are adjusted accordingly so stale/missing artifacts cannot be
used.
---
Nitpick comments:
In @.github/workflows/update-documentation.yml:
- Around line 46-50: Remove the "Regenerate documentation" step that echoes and
runs php bin/generate_llms_full.php from the workflow (the step with name
"Regenerate documentation") because llms-full.txt regeneration is redundant;
delete the two lines that run the echo and the php command and remove the whole
step block, and then also remove the PHP setup step (the job/step that installs
PHP) since it will no longer be needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a10f4967-9176-47c6-823d-8796544c332f
📒 Files selected for processing (6)
.github/workflows/jekyll.yml.github/workflows/update-documentation.yml.gitignorebin/README.mdbin/serve_local.shllms-full.txt
💤 Files with no reviewable changes (1)
- llms-full.txt
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
Verification
Note: local Jekyll build was not run successfully because required bundle gems are not installed in this local environment.
Summary by CodeRabbit
Chores
Documentation
Bug Fixes