Update documentation site navigation#100
Conversation
Removed redundant image tag from README and adjusted layout.
|
@coderabbitai review This PR updates the documentation site navigation and language flow. Please review the docs homepage language switching, README documentation entry point, added BDR docs pages, English tutorial, Japanese manual updates, and the readonly lazy-loading example fix. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get PR details and list of changed files
gh pr view 100 --repo ray-di/Ray.MediaQuery --json title,body,files,headRefName
echo "=== Changed files ==="
gh pr diff 100 --repo ray-di/Ray.MediaQuery --name-onlyLength of output: 2379 🏁 Script executed: #!/bin/bash
# Get the full diff for the PR
gh pr diff 100 --repo ray-di/Ray.MediaQueryLength of output: 144501 🏁 Script executed: #!/bin/bash
echo "=== Check for .note CSS class usage ==="
rg '\.note\b|class="note"' docs/ --type=html --type=css -n
echo ""
echo "=== Check remaining links pointing to /tutorial/ that may need /tutorial/ja/ ==="
rg '/tutorial/' docs/ --include='*.md' --include='*.html' --include='*.yml' -n
echo ""
echo "=== Check for any remaining 'Feature Reference' text in docs ==="
rg -i 'feature.reference' docs/ -n
echo ""
echo "=== Check if the old /tutorial/ permalink exists anywhere now ==="
rg 'permalink.*tutorial' docs/ --include='*.md' --include='*.html' -n
echo ""
echo "=== Check for broken relative links in bdr-pattern docs ==="
rg 'relative_url' docs/bdr-pattern.md docs/bdr-pattern-ja.md -nLength of output: 2308 🏁 Script executed: #!/bin/bash
echo "=== Check remaining links pointing to /tutorial/ ==="
rg '/tutorial/' docs/ -n --type md --type html
echo ""
echo "=== Check permalinks for tutorial pages ==="
rg 'permalink.*tutorial' docs/ -n --type md --type html
echo ""
echo "=== Check for stale links in root-level BDR_PATTERN files ==="
rg '/tutorial/' BDR_PATTERN.md BDR_PATTERN-ja.md README.md -n
echo ""
echo "=== Check the tutorial/README.ja.md link to English tutorial ==="
grep -n 'tutorial' docs/tutorial/README.ja.md | head -20
echo ""
echo "=== Verify docs/index.html Japanese section has no lead paragraph ==="
grep -n 'lead\|data-lang="ja"' docs/index.html | head -20
echo ""
echo "=== Check any links in docs still pointing to old Feature Reference ==="
rg 'Feature Reference|feature.reference' docs/ -n --type md --type html
echo ""
echo "=== Check docs/bdr-pattern.md and bdr-pattern-ja.md have correct permalinks ==="
grep 'permalink' docs/bdr-pattern.md docs/bdr-pattern-ja.mdLength of output: 8585
OverallThe PR is well-structured. The language-switching homepage, consolidated docs entry point, new BDR pages, English tutorial, Japanese manual, and the 1.
|
| # | File | Severity | Status |
|---|---|---|---|
| 2 | docs/tutorial/README.ja.md permalink change |
Medium | Suggest redirect stub |
| 3 | docs/tutorial/README.md Line 1749 description |
Low | Easy fix |
| 4 | docs/index.html Japanese hero lead |
Low | Polish |
| 5 | No-JS both-language visibility | Info | Optional |
| 6 | CHANGELOG.md wording |
Nit | Optional |
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR comprehensively restructures Ray.MediaQuery documentation to emphasize the Business Domain Repository pattern as a read-side query object architecture. It adds two new full implementation guides (English and Japanese), introduces a hands-on tutorial, implements bilingual site support with language switching, and updates navigation/landing pages. ChangesDocumentation & Site Restructuring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Clarify CQRS guidance in BDR FAQ
Summary
Validation
git diff c4ada94^..c4ada94 --checkjekyll build -s docs -d /tmp/ray-mediaquery-siteSummary by CodeRabbit
Release Notes
New Features
Documentation
Style