Add baseline unit coverage for schema parsing and YAML generation#10
Draft
Copilot wants to merge 2 commits into
Draft
Add baseline unit coverage for schema parsing and YAML generation#10Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/rawkode/kubectl-ditto/sessions/1cf837b1-55d5-4456-8cb3-33d3a6b45417 Co-authored-by: rawkode <145816+rawkode@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test coverage for codebase modules
Add baseline unit coverage for schema parsing and YAML generation
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codebase had no tests around its highest-risk logic: OpenAPI schema resolution/parsing and YAML scaffold generation. This adds targeted unit coverage for those paths without changing runtime behavior.
Schema parsing coverage
src/schema.rsfor definition-key selection across matching strategies.$refresolution, required-field propagation, enums/defaults, arrays, andadditionalPropertiesmaps.Ctxflow to verify nested object expansion and map value typing.YAML generation coverage
src/generate.rsforfilter_fieldsbehavior in--minimal, default, and fallback cases.is_commonly_neededheuristic against representative included/excluded fields.YamlNodeemitter for nested objects, arrays, inline comments, and free-form map placeholders.Approach
#[cfg(test)]modules in the two core files.