Fix CI gates: govuln, gofmt/goimports, pinned lint#60
Merged
Conversation
Resolves GO-2026-5039 (net/textproto) and GO-2026-5037 (crypto/x509), both fixed in go1.26.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The main CI pipeline was red on two gates unrelated to the format-positional merge: govulncheck (stdlib vulns fixed in go1.26.4) and formatting drift in test files that
golangci-lint'srun.tests: falsenever checked. This brings every gate green and adds enforcement so format drift can't recur regardless of which files a PR touches.Fix
toolchain go1.26.4— resolvesGO-2026-5039(net/textproto) andGO-2026-5037(crypto/x509).make fmt-check(gofmt + goimports, whole tree including tests) wired into CI's lint job andmake check;make fmtnow applies goimports too.golangci-linttov2.12.1so its bundled formatter can't drift from the toolchain's gofmt.Verified green:
make fmt-check,go vet ./...,golangci-lint run ./...(0 issues),go test -race ./...,govulncheck ./...(0 vulns),gosec ./....