Venice warning fix

[DeStup]

i quess it's not necessary anymore? I received a caravan in technology without going over the limit

[SeventhM]

Removing the unique entirely feels wrong. The cargo ship should always take up a a trade route, so removing the unique entirely is almost definitely wrong

What the warning is actually saying something which I missed previously: the conditional itself is wrong ("upon" discovering the tech only works for triggerables, which this is not. It should be "after" discovering the tech)

[DeStup]

Removing the unique entirely feels wrong. The cargo ship should always take up a a trade route, so removing the unique entirely is almost definitely wrong

What the warning is actually saying something which I missed previously: the conditional itself is wrong ("upon" discovering the tech only works for triggerables, which this is not. It should be "after" discovering the tech)

i change to
"Provides [1] [Trade Route] <after discovering [Compass]>",
"Free [Cargo Ship] appears <upon discovering [Compass] technology>"
and look at this:

thats why i decided that it is not necessary. The caravan that appears does not require trade route.
At the same time, if you build normally in the city, it will consume trade route.

[SeventhM]

That's... Uhhhhhhhhh....

Wait a sec, do you stay +1 trade route after passing the turn?

[DeStup]

That's... Uhhhhhhhhh....

Wait a sec, do you stay +1 trade route after passing the turn?

yeah

[SeventhM]

I'm doing all this checking and trying to debug, and I just realized I'm dumb

i change to
"Provides [1] [Trade Route] <after discovering [Compass]>",
"Free [Cargo Ship] appears <upon discovering [Compass] technology>"
and look at this:

Working as intended, please change this PR to that. The extra Trade Route you're seeing is not from Venice's UA, but from Compass itself

[DeStup]

@SeventhM Review please. I got a little confused and then I forgot.

[SeventhM]

Sorry. Week's been very busy, I still have been slowing trying to find documentation on various Lekmod stuff (I hadn't checked their github because I wasn't sure if it was up to date), and tbh have been mostly focusing my attention on base Unciv stuff. Otherwise, I would've merged my own fix already. Merging this now

[SeventhM]

Btw, it's so annoying how much of the latest new features of Lekmod is hardcoded and not visible in the xml file