Stabilize flaky test_ravenDB_16334 (reference-reindex race)#298
Merged
poissoncorp merged 1 commit intoJun 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_can_wait_for_indexes_with_load_after_save_changes_*intermittently fails in CI:MyIndexprojectsrelated/Ainto the result viaLoadDocument. The first query (line 60) is guarded bywait_for_indexing(line 57), but the second query (after updatingrelated.value = 42) relies solely onwait_for_indexes_after_save_changes. Updating a referenced document marks the index stale asynchronously, so the assertion occasionally observes the stale21.5.Fix
Add
self.wait_for_indexing(self.store)before the second assertion, mirroring the guard already used before the first query. Fixes both the_single_indexand_all_indexesvariants (shared_internalhelper). Thewait_for_indexes_after_save_changescall is kept so that code path is still exercised.No production code changed — test-only.