Improve Displayed Text for Logical Line Count When Metric is Unvailable #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes how count results for logical lines are shown by scount. For individual files, summary rows and the total row, as well as for single file inputs, if the corresponding source file entity has a format for which logical lines cannot be computed, the shown result number is displayed as a 'n/a' label. Adds the bool 'hasLogicalLines' field to the RcnCountResultGroup type to expose the needed information to scount. Signed-off-by: kilo52 <phil.gaiser@raven-computing.com>
Signed-off-by: kilo52 <phil.gaiser@raven-computing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes how count results for logical lines are shown by scount. For individual files, summary rows and the total row, as well as for single file inputs, if the corresponding source file entity has a format for which logical lines cannot be computed, the shown result number is displayed as a 'n/a' label.
Adds the bool
hasLogicalLinesfield to theRcnCountResultGrouptype to expose the needed information toscount.