Add Option to scount to Stop on Error #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an option to stop the process as soon as the first error is encountered. Without the option, some errors might get ignored. For example, when a source file contains syntax errors and thus the logical line count cannot be computed, the scount will skip that file and continue normally with the rest of the files to process. With the --stop-on-error option specified on the command-line, the process stops when the file with a syntax error is encountered and the processed RcnCountStatistics struct is flagged as erroneous. Renamed the files inside the 'mixedWithSyntaxError' test resource directory to have the erroneous source files placed in the middle, as scanned files are always sorted by libreckon. Adjusted other tests accordingly. Changed internal count() implementation in libreckon to copy the erroneous state to the RcnCountStatistics struct being processed so that it is available to the caller. Signed-off-by: kilo52 <phil.gaiser@raven-computing.com>
Signed-off-by: kilo52 <phil.gaiser@raven-computing.com>
Signed-off-by: kilo52 <phil.gaiser@raven-computing.com>
Signed-off-by: kilo52 <phil.gaiser@raven-computing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
--stop-on-errorCLI option.Adds an option to stop the process as soon as the first error is encountered. Without the option, some errors might get ignored. For example, when a source file contains syntax errors and thus the logical line count cannot be computed, the
scountwill skip that file and continue normally with the rest of the files to process. With the--stop-on-erroroption specified on the command-line, the process stops when the file with a syntax error is encountered and the processedRcnCountStatisticsstruct is flagged as erroneous.Renames the files inside the 'mixedWithSyntaxError' test resource directory to have the erroneous source files placed in the middle, as scanned files are always sorted by libreckon. Adjusts other tests accordingly.
Changes internal count() implementation in libreckon to copy the erroneous state to the
RcnCountStatisticsstruct being processed so that it is available to the caller.