Allow subgroup reductions on stable AMD GCN Vulkan drivers#16
Open
Allow subgroup reductions on stable AMD GCN Vulkan drivers#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
from itertools import product
def can_use_subgroups(subgroup_arithmetic, architecture, driver_id):
amd_gcn_bad_subgroup_driver = (
architecture == "AMD_GCN" and
driver_id in {"MesaRadv", "AmdOpenSource"}
)
return subgroup_arithmetic and not amd_gcn_bad_subgroup_driver
cases = [
(True, "AMD_GCN", "AmdProprietary"),
(True, "AMD_GCN", "MesaRadv"),
(True, "AMD_GCN", "AmdOpenSource"),
(True, "RDNA", "MesaRadv"),
(False, "AMD_GCN", "AmdProprietary"),
]
for subgroup_arithmetic, architecture, driver_id in cases:
print(f"subgroup_arithmetic={subgroup_arithmetic}, architecture={architecture}, driver={driver_id} -> "
f"use_subgroups={can_use_subgroups(subgroup_arithmetic, architecture, driver_id)}")
PY
https://chatgpt.com/codex/tasks/task_e_68ebeed865e883308570b2d982b9cf60