Skip to content

CI: Build presto dependency container image by default instead of fetching it from s3#207

Merged
Avinash-Raj merged 1 commit intomainfrom
presto-build-dependency-image-by-default-instead-of-fetching-from-s3
Feb 4, 2026
Merged

CI: Build presto dependency container image by default instead of fetching it from s3#207
Avinash-Raj merged 1 commit intomainfrom
presto-build-dependency-image-by-default-instead-of-fetching-from-s3

Conversation

@Avinash-Raj
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI workflow to build Presto dependency container images locally by default rather than downloading them from S3. This change aims to reduce dependency on external S3 storage and provides more flexibility in CI execution.

Changes:

  • Added a new build_dependency_image input parameter (defaulting to true) to control whether dependency images are built locally or fetched from S3
  • Updated workflow jobs to pass the new parameter through the workflow chain
  • Added conditional logic to build or download the dependency image based on the parameter value

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/presto-test.yml Adds build_dependency_image input parameter and passes it to all dependent jobs (java, native-cpu, native-gpu)
.github/workflows/presto-test-composite.yml Implements the build/download logic with conditional steps based on the new parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

description: 'Set VELOX_ENABLE_BACKWARD_COMPATIBLE in Velox build'
type: boolean
default: false
build_dependency_image: &build_dependency_image
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using YAML anchors for workflow inputs is unconventional and may not work as expected across workflow_dispatch and workflow_call trigger types. GitHub Actions typically requires explicit input definitions for each trigger type. Consider defining the input separately for each trigger or verifying this works correctly in your GitHub Actions environment.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Avinash-Raj can we assume this concern is unfounded, as we are already using the same semantics for the other parameters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we don't need to worry about it. Since we already have our workflows working with those anchors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as-is.

Copy link
Contributor

@simoneves simoneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the Copilot concern is unfounded

description: 'Set VELOX_ENABLE_BACKWARD_COMPATIBLE in Velox build'
type: boolean
default: false
build_dependency_image: &build_dependency_image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Avinash-Raj can we assume this concern is unfounded, as we are already using the same semantics for the other parameters?

description: 'Set VELOX_ENABLE_BACKWARD_COMPATIBLE in Velox build'
type: boolean
default: false
build_dependency_image: &build_dependency_image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as-is.

@Avinash-Raj Avinash-Raj merged commit 6fe5a0e into main Feb 4, 2026
5 of 6 checks passed
@Avinash-Raj Avinash-Raj deleted the presto-build-dependency-image-by-default-instead-of-fetching-from-s3 branch February 4, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants