Add pre-commit config #191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
commented
Jan 27, 2026
| quiet-level = 3 | ||
|
|
||
| [tool.ruff] | ||
| line-length = 120 |
Contributor
Author
There was a problem hiding this comment.
I am fine with any value here and don't want this to become a point for bikeshedding this PR. I chose 120 for now to make the diff as small as possible (the fewer changes, the easier to review). If anyone has a preference on what this value should be, I recommend we defer that discussion to a follow-up PR.
| import pyarrow.parquet as pq | ||
|
|
||
| from .common_fixtures import setup_and_teardown, get_all_parquet_relative_file_paths | ||
| from .common_fixtures import get_all_parquet_relative_file_paths |
Contributor
Author
|
I'm going to cut the scope of this so we can start adding basic CI checks. I'll keep this to only whitespace/end-of-file fixes and copyright fixes for now. |
- Resolved merge conflicts between shellcheck fixes and upstream SCRIPT_DIR changes - Fixed SC2086 (quote variables) in new slurm scripts - Fixed SC2155 (declare and assign separately) - Fixed SC2129 (group redirects) - Added missing copyright headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
.pre-commit-config.yamlto get this repo up to speed with NVIDIA copyright requirements and the bare minimum of code style enforcement.As a follow-up we can enable CI checks to enforce these.