Small script fixes needed to run in gitlab environment#188
Small script fixes needed to run in gitlab environment#188misiugodfrey wants to merge 8 commits intomainfrom
Conversation
| if not os.path.isdir(external_dir): | ||
| data_dir = get_abs_file_path("data") | ||
| raise Exception(f"external location '{external_dir}' referenced by table hive.{schema_name}.{table} \ | ||
| does not exist in {get_abs_file_path("data")} or $PRESTO_DATA_DIR") |
There was a problem hiding this comment.
ARM currently has to use python3.10 when running this script, and it does not like this syntax. Changed it so that it is semantically equivalent but works with python3.10.
| parser.addoption("--profile-script-path") | ||
|
|
||
|
|
||
| def pytest_sessionstart(session): |
There was a problem hiding this comment.
Some runner environment were complaining that benchmark_results was unset.
There was a problem hiding this comment.
Can you please expand on this? Where was this error coming from?
There was a problem hiding this comment.
I think this was potentially related to another error. The problem is that the benchmark_results is only created in the teardown, which means if the tests were not run it will not be created; however, it is referenced in the terminal_summary regardless.
This was leading to misleading error messages that I needed to fix before I could find the actual problem. They may not occur anymore, but I think we should consider leaving this in place for the sake of future debugging.
There was a problem hiding this comment.
which means if the tests were not run it will not be created;
I believe this is expected.
however, it is referenced in the terminal_summary regardless.
So we should probably update pytest_terminal_summary and pytest_sessionfinish to skip or do something different in this case?
3 participants
No description provided.