Open
Conversation
We can't stratify metadata tags by finish or normal metadata because in that scenario we can still accidentally end up posting metadata receives that will be matched by the next collective. Instead change the event loop to satisfy the correct invariant for metadata receive posting: we post at most one receive per event loop iteration and act on it appropriately. If it is a finish chunk we update the number of expected messages (and hence the number of additional metadata receives we expect to send), otherwise it's a data chunk and we update the number of received messages. This way the metadata receive is never a greedy loop that can eat sends from a subsequent collective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't stratify metadata tags by finish or normal metadata because in that scenario we can still accidentally end up posting metadata receives that will be matched by the next collective.
Instead change the event loop to satisfy the correct invariant for metadata receive posting: we post at most one receive per event loop iteration and act on it appropriately. If it is a finish chunk we update the number of expected messages (and hence the number of additional metadata receives we expect to send), otherwise it's a data chunk and we update the number of received messages. This way the metadata receive is never a greedy loop that can eat sends from a subsequent collective.