-
Notifications
You must be signed in to change notification settings - Fork 32
Add OrderScheme partitioning metadata
#853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rjzamora
wants to merge
23
commits into
rapidsai:main
Choose a base branch
from
rjzamora:orderscheme-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
b145819
Add OrderScheme partitioning metadata
rjzamora 5fb6d2f
Merge branch 'main' into orderscheme-metadata
rjzamora fec05ee
Merge branch 'main' into orderscheme-metadata
rjzamora 6c08a84
Merge branch 'main' into orderscheme-metadata
rjzamora 215a757
Merge branch 'main' into orderscheme-metadata
rjzamora 5461cc2
Merge branch 'main' into orderscheme-metadata
rjzamora 1011476
Merge branch 'main' into orderscheme-metadata
rjzamora 0818a8a
Merge branch 'main' into orderscheme-metadata
rjzamora 103930a
update
rjzamora fbd5009
Merge remote-tracking branch 'upstream/main' into orderscheme-metadata
rjzamora f736ef9
address code review and clean up
rjzamora 7a2e9ba
rewrite OrderScheme API
rjzamora 760605b
address review
rjzamora 7b1bfa5
Merge remote-tracking branch 'upstream/main' into orderscheme-metadata
rjzamora ba63956
make boundaries spillable
rjzamora 8efb567
spilling test
rjzamora 76f3bb1
Merge branch 'main' into orderscheme-metadata
rjzamora 82d3730
Merge remote-tracking branch 'upstream/main' into orderscheme-metadata
rjzamora 40de4e8
fix spillablemessages
rjzamora 1609f66
accept suggestion
rjzamora 6bb185b
simplify
rjzamora 3544505
heavy revisions
rjzamora 2bd1a26
avoid unnecessary aliases
rjzamora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Can one have both
hashandorderfor the same partitioningspec?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose you could, but hash is ignored unless type is HASH and order is ignored unless type is ORDER. In the absence of Cython, I would never design it this way, but I remember we landed on this after I struggled with HashScheme.