Refactor hardware access with dependency injection#137
Draft
mmccarty wants to merge 3 commits intorapidsai:mainfrom
Draft
Refactor hardware access with dependency injection#137mmccarty wants to merge 3 commits intorapidsai:mainfrom
mmccarty wants to merge 3 commits intorapidsai:mainfrom
Conversation
28e3957 to
126bca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rapids_cli/hardware.pywith provider abstractions:DeviceInfodataclass,GpuInfoProvider/SystemInfoProviderprotocols,NvmlGpuInfo/DefaultSystemInforeal implementations (lazy-loading, cached), andFakeGpuInfo/FakeSystemInfo/FailingGpuInfo/FailingSystemInfotest fakesgpu.py,cuda_driver.py,memory.py,nvlink.py, anddebug.pyto accept optional provider parameters instead of callingpynvml/psutil/cuda.pathfinderdirectlydoctor.pyto create a sharedNvmlGpuInfoinstance and pass it to all checksmock.patch— eliminates ~51 hardware patches and ~11MagicMockobjects from those teststest_hardware.pywith 19 tests for all provider implementationsnvmlDeviceGetNvLinkState(handle, 0)always passed0instead of actualnvlink_idNote: This branch includes commits from #135 (tests) and #136 (docs). The DI-specific changes are in commit
28e3957.Test plan
pytest— all 72 tests passpre-commit run --all-filespasses🤖 Generated with Claude Code