Skip to content

trim docs environment#80

Open
jameslamb wants to merge 1 commit intorapidsai:release/26.04from
jameslamb:misc/docs-build
Open

trim docs environment#80
jameslamb wants to merge 1 commit intorapidsai:release/26.04from
jameslamb:misc/docs-build

Conversation

@jameslamb
Copy link
Member

Replaces #57, which I accidentally closed by deleting my fork when the repo was flipped to public.

The docs group in rapids-dependency-file-generator currently re-declares a couple of dependencies which are only needed because they're direct dependencies of libnvforest / nvforest.

Those should just be pulled through directly via installing libnvforest / nvforest:

CPP_CHANNEL=$(rapids-download-conda-from-github cpp)
PYTHON_CHANNEL=$(rapids-download-from-github "$(rapids-package-name conda_python nvforest --stable --cuda)")

This removes them from that list, so the docs environment will get smaller if those dependencies are ever removed here.

@jameslamb jameslamb requested a review from hcho3 March 11, 2026 15:18
@jameslamb jameslamb requested a review from a team as a code owner March 11, 2026 15:18
@jameslamb jameslamb requested a review from AyodeAwe March 11, 2026 15:18
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 11, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e38b7f97-5fe7-4179-bbf1-946877535b96

📥 Commits

Reviewing files that changed from the base of the PR and between ea0302b and 1fe1364.

📒 Files selected for processing (1)
  • dependencies.yaml
💤 Files with no reviewable changes (1)
  • dependencies.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed dependencies from build and documentation configurations, simplifying setup and reducing the dependency footprint across development and documentation environments.

Walkthrough

Three dependency entries (depends_on_cuda_python, depends_on_libraft_headers, depends_on_librmm) were removed from both the "all" and "docs" dependency groups in dependencies.yaml. No structural changes or remaining include modifications.

Changes

Cohort / File(s) Summary
Dependency Configuration
dependencies.yaml
Removed three dependency includes (depends_on_cuda_python, depends_on_libraft_headers, depends_on_librmm) from both "all" and "docs" groups.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • hcho3
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'trim docs environment' clearly and concisely summarizes the main change: removing dependencies from the docs group to reduce its size.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for removing dependencies from the docs group and referencing the upstream nvforest repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@jameslamb jameslamb changed the base branch from main to release/26.04 March 12, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants