Skip to content

ScaNN: Fix AVQ prefetch #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmaschal wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ScaNN: Fix AVQ prefetch #1899

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d97099b
ScaNN: Fix AVQ prefetch
rmaschal Mar 9, 2026
22f74e7
Copy resources instead of setting stream
rmaschal Mar 10, 2026
2e18ef7
Merge branch 'main' into fix-avq-prefetch
rmaschal Mar 12, 2026
6d5453d
Merge branch 'main' into fix-avq-prefetch
rmaschal Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cpp/src/neighbors/scann/detail/scann_avq.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,11 +511,16 @@ class cluster_loader {
raft::make_device_matrix_view<float, int64_t>(d_cluster_copy_buf_.data_handle(), size, dim_);

if (needs_copy_) {
// For prefetching to overlap with other gpu work
// we need to schedule copies on the provided copy stream stream_
auto copy_res = raft::resources(res);
raft::resource::set_cuda_stream(copy_res, stream_);

// htod
auto h_cluster_ids =
raft::make_pinned_vector_view<LabelT, int64_t>(cluster_ids_buf_.data_handle(), size);

raft::copy(res, h_cluster_ids, cluster_ids);
raft::copy(copy_res, h_cluster_ids, cluster_ids);
raft::resource::sync_stream(res, stream_);

auto pinned_cluster = raft::make_pinned_matrix_view<T, int64_t>(
Expand All @@ -529,9 +534,8 @@ class cluster_loader {
sizeof(T) * dim_);
}

raft::copy(res, cluster_vectors, raft::make_const_mdspan(pinned_cluster));
raft::copy(copy_res, cluster_vectors, raft::make_const_mdspan(pinned_cluster));
raft::resource::sync_stream(res, stream_);

} else {
// dtod
auto dataset_view =
Expand Down
Loading