Open
Conversation
…ncies (#5453) Contributes to rapidsai/build-planning#257 * ensures that when `torch` is installed in wheels CI, it's always a CUDA variant * removes unused test dependencies `ogb`, `pydantic`, `torchdata`, and `torchmetrics` - *I suspect these are left over from before GNN packages moved out to https://github.com/rapidsai/cugraph-gnn* ## Notes for Reviewers ### How does this help with testing against a mix of CTKs? `torch` CUDA wheels tightly pin to `nvidia-{thing}` wheels and soon, `cuda-toolkit` (see rapidsai/build-planning#255). Forcing the use of CUDA `torch` wheels ensures we'll catch dependency conflicts in CI. Without this, `pip` could silently fall back to CPU-only `torch` from pypi.org. ### How I tested this This PR uses some patterns I've tested elsewhere too: * rapidsai/rmm#2270 (comment) * rapidsai/cugraph-gnn#425 I also tested a commit here with both the PR and nightly test matrices, to be sure we covered everything: https://github.com/rapidsai/cugraph/actions/runs/23062364778/job/66996357196?pr=5453 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) - Gil Forsyth (https://github.com/gforsyth) URL: #5453
Author
|
FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.04 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.