De-vendor CMake dependencies and use shared libraries#753
De-vendor CMake dependencies and use shared libraries#753gigony wants to merge 25 commits intorapidsai:branch-25.04from
Conversation
|
/ok to test |
|
Thanks Gigon! 🙏 Moved this to 24.10. Hope that is ok 🙂 |
|
/ok to test |
2 similar comments
|
/ok to test |
|
/ok to test |
In conda-forge this is called Though I wonder if we want to use rapids-cmake's |
|
/ok to test |
1 similar comment
|
/ok to test |
cuLIBOS is a static library that is included as part of CUDART and installed with the NVCC compiler In terms of finding it, CMake already has FindCUDAToolkit, which includes a So we can probably drop this file and simplify associated logic |
|
/ok to test |
|
@jakirkham It looks like the build container is out of space. https://github.com/rapidsai/cucim/actions/runs/10206351504/job/28239540987?pr=753 |
|
Do we know how much space we are using? |
jakirkham
left a comment
There was a problem hiding this comment.
If we just need Boost headers, we can make this change
|
/ok to test |
|
Style check failure is due to a small typo. Fixing in PR: #759 |
7a66c5e to
924aa0a
Compare
|
Rebased Edit: Hoped that would mean GitHub would sign all the commits for us, but it seems that didn't work |
|
#785 (comment) for devendoring libtiff |
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Remove workarounds that address the following errors: Use generator expression to avoid `nvcc fatal : Value '-std=c++17' is not defined for option 'Werror'` Signed-off-by: Gigon Bae <gbae@nvidia.com>
Do not use catch_discover_tests() since it causes a test to be run at build time and somehow it causes a deadlock during the build. Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
It looks like the RAPIDS CI/CD is launching the docker container with a reduced shared memory size. This is causing the shared memory cache to be failed with 'RuntimeError: No space left on device'. Signed-off-by: Gigon Bae <gbae@nvidia.com>
|
Retargeted to 25.04 Note there are some conflicts introduced from PR: #834 |
This patch de-vendors CMake dependencies and use/link shared libraries as much as possible.
Devendor CMake dependencies #686
Switch to build with CXX11 ABI because we are now building manylinux_2_28 wheel.
_GLIBCXX_USE_CXX11_ABI=0because manylinux2014 requires gcc4-compatible libstdcxx-abi(gcc is configured with '--with-default-libstdcxx-abi=gcc4-compatible', https://gcc.gnu.org/onlinedocs/libstdc++/manual/configure.html) which forces to set_GLIBCXX_USE_CXX11_ABI=0sostd::pmr::stringwouldn't be available on CentOS 7.Update
tests/unit/clara/test_image_cache.py::test_get_shared_memory_cacheto reduce the shared memory size.FAILED tests/unit/clara/test_image_cache.py::test_get_shared_memory_cache - RuntimeError: No space left on deviceTasks
CONDA_PREFIXenvironment variable is not available).Added conda packages (for build)
Test procedure
using docker
using conda locally