Fix Cube Rendering in scene_render Test #9
Conversation
The scene_render test was not displaying the cube because of a data type mismatch for mesh indices. The code used 'int' while OpenGL's glDrawElements expected 'unsigned int'. This commit changes the mesh index data type to 'unsigned int' in Mesh.hpp and updates GameObject.cpp accordingly, resolving the rendering issue.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
The
scene_rendertest was failing to render a cube due to a mismatch between the C++inttype used for mesh indices and theGL_UNSIGNED_INTexpected by OpenGL. This commit corrects the data type of mesh indices tounsigned intthroughout the relevant files, ensuring the cube is rendered correctly.PR created automatically by Jules for task 6342090681910972856 started by @randomnumgen1