Open
Conversation
noxecane
suggested changes
Jul 6, 2021
Contributor
noxecane
left a comment
noxecane
left a comment
There was a problem hiding this comment.
For SiberMetrics
There's no pointer to the existing use of SiberMetrics in siber
For autoloadEnv
It would be better to separate the process for using autoloadEnv from the explanation of existing env schemas and types
noxecane
reviewed
Jul 8, 2021
Contributor
noxecane
left a comment
noxecane
left a comment
There was a problem hiding this comment.
expecting fixes as discussed
allengblack
suggested changes
Jul 19, 2021
README.md
Outdated
|
|
||
| ## What is SiberMetrics and how it works. | ||
|
|
||
| SiberMetrics are routers around prometheus client for node.js to record and export a histogram of an http request. |
Contributor
There was a problem hiding this comment.
Routers or "wrappers"?
Contributor
There was a problem hiding this comment.
Capitalise Prometheus, NodeJS.
| }) | ||
| ``` | ||
|
|
||
| ## What is SiberMetrics and how it works. |
Contributor
There was a problem hiding this comment.
It's not quite a "histogram of an HTTP request".
https://prometheus.io/docs/introduction/overview/
allengblack
reviewed
Jul 27, 2021
| * @param schema schema to use for validation | ||
| */ | ||
| export function autoloadEnv<T extends AppConfig>(schema: ObjectSchema): T { | ||
| export function autoloadEnv<T>(schema: ObjectSchema): T { |
Contributor
There was a problem hiding this comment.
Why did you change these?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes