Add post-provisioning check for ETCD S3 configuration#488
Add post-provisioning check for ETCD S3 configuration#488navsalehi wants to merge 1 commit intorancher:mainfrom
Conversation
|
S3SnapshotRestoreTestSuite TestS3SnapshotRestore TestSuites above were modified. TestSuites below use modified code from this PR. |
navsalehi
force-pushed
the
s3-snapshot-enhancement
branch
from
15b41bb to
96294e2
Compare
|
S3SnapshotRestoreTestSuite TestS3SnapshotRestore TestSuites above were modified. TestSuites below use modified code from this PR. |
navsalehi
force-pushed
the
s3-snapshot-enhancement
branch
from
96294e2 to
0207e11
Compare
|
S3SnapshotRestoreTestSuite TestS3SnapshotRestore TestSuites above were modified. TestSuites below use modified code from this PR. |
add rke2 and rke1 add package remove rke1
navsalehi
force-pushed
the
s3-snapshot-enhancement
branch
from
0207e11 to
17295de
Compare
|
S3SnapshotRestoreTestSuite TestS3SnapshotRestore TestSuites above were modified. TestSuites below use modified code from this PR. |
markusewalker
left a comment
markusewalker
left a comment
There was a problem hiding this comment.
Overall, LGTM, nice job! Left one comment and will await offline test results to make sure all is well.
| err = etcdsnapshot.CreateAndValidateSnapshotRestore(s.client, cluster.Name, tt.etcdSnapshot, containerImage) | ||
| require.NoError(s.T(), err) | ||
|
|
||
| err = etcdsnapshot.VerifyS3Config(s.cluster) |
There was a problem hiding this comment.
This can be moved to be immediately after the ProvisionRKE2K3SCluster function. For existing clusters and non-existing clusters.
2 participants
This PR adds a post-provisioning validation to S3 snapshot restore tests to ensure the cluster was created with ETCD S3 configuration enabled.