Open
Conversation
|
I'd like to second that this PR be merged with main. |
|
I would highly appreciate a fix for #224 but suggest that |
wombelix
added a commit
to wombelix/fork_rancher_quickstart
that referenced
this pull request
Nov 8, 2024
Filter for 'Windows_Server-2019-English-Full-Base*' to avoid that flavours like SQL Server or Core are part of the results. Refs: rancher#236 (comment)
871fc03 to
66ecc11
Compare
Author
|
Good point @wombelix, I made the change according to your suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #224
Following the AWS quickstart instructions results in the following Terraform error:
This AMI no longer exists. When the fix in this PR is applied, it matches
ami-06404b83fffc8f0cain myeu-west-3region, and resolves toWindows_Server-2019-English-Full-SQL_2019_Web-2024.06.13.