Docs: complete agent-readable bounty template#558
Conversation
📝 WalkthroughWalkthroughAdds an agent-readable bounty template to docs, implements it as a GitHub issue template, updates admin runbook guidance, and enforces the shape via docs smoke validations and unit tests. ChangesBounty Template Standardization
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Baijack-star
left a comment
There was a problem hiding this comment.
Reviewed PR #558 at current head 154a4648efafff52304290bbc22c6ccd7bf07674 for the #456 agent-readable bounty template docs/form slice.
I do not see a docs/test blocker in the current diff. The PR adds a copy-pasteable stable-heading template in docs/bounty-rules.md, updates the maintainer runbook to require the title/reward/max-awards/body shape, makes evidence, out_of_scope, and duplicate/stale rules required in .github/ISSUE_TEMPLATE/bounty.yml, and adds docs-smoke coverage for the new template and issue-form fields.
Evidence checked:
- inspected
.github/ISSUE_TEMPLATE/bounty.yml,docs/admin-runbook.md,docs/bounty-rules.md, andscripts/docs_smoke.py; - compared the scope against #456 acceptance criteria: title format, reward/max-awards repetition, stable headings, evidence/out-of-scope/duplicate/stale fields, API/MCP/GitHub parsing rationale, and public-artifact cautions are present;
- compared against already-open #469 and #499: this is the same bounty surface, so maintainers should merge/pay at most one winner, but #558 is a coherent implementation and protects more of the template shape than #499 by including docs-smoke checks.
Validation run locally on this head:
PYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /Users/apple/Documents/paid-demand-goal-reset/mergework-review/.venv/bin/python scripts/docs_smoke.py-> docs smoke okPYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /Users/apple/Documents/paid-demand-goal-reset/mergework-review/.venv/bin/python -m pytest tests/test_docs_public_urls.py tests/test_check_agents.py -q-> 25 passedPYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /Users/apple/Documents/paid-demand-goal-reset/mergework-review/.venv/bin/python -m pytest -q-> 414 passed/Users/apple/Documents/paid-demand-goal-reset/mergework-review/.venv/bin/python -m ruff check .-> passed/Users/apple/Documents/paid-demand-goal-reset/mergework-review/.venv/bin/python -m ruff format --check .-> 79 files already formattedPYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /Users/apple/Documents/paid-demand-goal-reset/mergework-review/.venv/bin/python -m mypy app-> successgit diff --check origin/main...HEAD-> clean
GitHub Quality/readiness/docs/image checks are successful on the same head. CodeRabbit was still pending when I posted this, so this review is scoped to the repository diff, local validation, and current GitHub CI state.
Baijack-star
left a comment
There was a problem hiding this comment.
Requesting changes for a narrow docs-smoke coverage gap.
The docs/form content itself is mostly aligned with #456, but scripts/docs_smoke.py does not actually protect all of the required issue-form fields that this PR adds and that #456 asks agents to rely on. It checks that id: evidence, id: out_of_scope, and id: duplicate_stale_rules exist, then only verifies that the out_of_scope block contains required: true. The new evidence and duplicate_stale_rules fields could be changed back to optional while docs smoke still prints docs smoke ok.
Concrete reproduction on head 154a4648efafff52304290bbc22c6ccd7bf07674:
- changed only
.github/ISSUE_TEMPLATE/bounty.ymlsoid: evidencehasrequired: false; - changed only
.github/ISSUE_TEMPLATE/bounty.ymlsoid: duplicate_stale_ruleshasrequired: false; - ran
PYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /Users/apple/Documents/paid-demand-goal-reset/mergework-review/.venv/bin/python scripts/docs_smoke.py; - result:
docs smoke ok.
That leaves the promised regression guard weaker than the PR summary and the bounty acceptance criteria. Please extend the docs smoke check to assert required: true inside the evidence, out_of_scope, and duplicate_stale_rules field blocks, or add an equivalent focused test that fails when any of those concrete required fields become optional.
Baseline validation on the unmodified PR head still passes:
PYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /Users/apple/Documents/paid-demand-goal-reset/mergework-review/.venv/bin/python scripts/docs_smoke.py-> docs smoke okPYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /Users/apple/Documents/paid-demand-goal-reset/mergework-review/.venv/bin/python -m pytest tests/test_docs_public_urls.py tests/test_check_agents.py -q-> 25 passedgit diff --check origin/main...HEAD-> clean
|
Reviewed current PR #558 head No blocker found on this head. Evidence checked:
This looks mergeable from my reviewed slice. |
Refs #456
Summary
Evidence
Compared this change against the current repository surfaces named in the bounty:
docs/bounty-rules.md: existing submission evidence templates and payout wordingdocs/admin-runbook.md: maintainer bounty posting and acceptance flow.github/ISSUE_TEMPLATE/bounty.yml: current issue form fieldsscripts/docs_smoke.py: existing public documentation checksreward_mrwk,max_awards,awards_remaining, labels, and public commentsThis version keeps the template copy-pasteable and uses stable headings:
## MRWK Bounty## Work Needed## Acceptance Criteria## How To Submit## Evidence or Tests Required## Out of Scope## Duplicate and Stale Work RulesAfter reviewer feedback, the current head also verifies that
evidence,out_of_scope, andduplicate_stale_rulesare all individually required fields.Test Evidence
python scripts/docs_smoke.py->docs smoke okpython -m pytest tests/test_docs_public_urls.py tests/test_check_agents.py -q->26 passedpython -m ruff check scripts/docs_smoke.py tests/test_docs_public_urls.py->All checks passed!python -m ruff format --check scripts/docs_smoke.py tests/test_docs_public_urls.py->2 files already formattedgit diff --check-> cleanOut of Scope