Refs #406: Accept backticked refs in submission gate#479
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR extends bounty reference parsing to recognize backticked issue numbers ( ChangesBackticked Bounty Reference Support
Possibly related PRs
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
carpedkm
left a comment
There was a problem hiding this comment.
Reviewed PR #479 at current head e416a9499450e0d31f9c189acfc6b556d0a89871. No blocker found.
Evidence checked:
- The diff is scoped to
scripts/submission_quality_gate.pyandtests/test_submission_quality_gate.py. - The regex change mirrors the already-reviewed queue-health behavior for optional inline-code backticks around
#<issue>after existing bounty/ref/fix/close/claim prefixes. - Existing plain forms still parse (
Refs #319), while the new common Markdown forms parse as intended (Refs#319and `/claim `#319). - A mixed reference body with
Bounty#319`` andRefs #406returns both refs, so the change preserves multi-reference behavior. - The added regression covers both prose and
/claimcommand bodies. - GitHub
Quality, readiness, docs, and image checksis passing.
Validation run locally on this head:
./.venv/bin/python -m pytest tests/test_submission_quality_gate.py -q->24 passed./.venv/bin/python -m pytest -q->415 passed./.venv/bin/python -m ruff check scripts/submission_quality_gate.py tests/test_submission_quality_gate.py-> passed./.venv/bin/python -m ruff format --check scripts/submission_quality_gate.py tests/test_submission_quality_gate.py->2 files already formatted./.venv/bin/python -m mypy scripts/submission_quality_gate.py-> success./.venv/bin/python scripts/docs_smoke.py-> docs smoke okgit diff --check origin/main...HEAD-> clean
This is a narrow parser usability fix and looks ready to merge from my review.
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Reviewed PR #479 at current head e416a9499450e0d31f9c189acfc6b556d0a89871 for Bounty #447.
I checked scripts/submission_quality_gate.py and tests/test_submission_quality_gate.py. The change is scoped to accepting inline-code bounty references such as Refs #319 and `/claim `#319 through the existing reference prefixes, while preserving plain Refs #319 behavior. I also spot-checked that mixed references still de-duplicate/sort correctly and that a backticked ref line is skipped when deriving the submission title.
Validation:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_submission_quality_gate.py -q-> 24 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest -q-> 415 passeduv run --extra dev ruff check scripts/submission_quality_gate.py tests/test_submission_quality_gate.py-> passeduv run --extra dev ruff format --check scripts/submission_quality_gate.py tests/test_submission_quality_gate.py-> 2 files already formatteduv run --extra dev python -m mypy scripts/submission_quality_gate.py-> successPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python scripts/docs_smoke.py-> docs smoke okgit diff --check origin/main...HEAD-> cleangit diff --no-ext-diff origin/main..HEAD | gitleaks stdin --no-banner --redact --exit-code 1-> no leaks founduv run --extra dev python -c 'from scripts.submission_quality_gate import _bounty_refs, _title_from_submission; print(_bounty_refs("Bounty#319\\nRefs #406\\n/claim#319")); print(_title_from_submission("Refs#319\\nFix parser title"))'->[319, 406]andfix parser title
GitHub readback before review showed the PR open/non-draft, merge state CLEAN, and both CodeRabbit plus project CI successful. No blockers found.
Summary
scripts/submission_quality_gate.pyto recognize Markdown inline-code bounty references such asRefs `#406`/claimcommand bodies with a focused regression testRefs #406.
Evidence
The submission quality gate currently recognizes
Refs #406and/claim #406, but common Markdown inline-code variants such asRefs `#406`or/claim `#406`are reported as missing bounty references. This can make a valid submission draft look invalid before a contributor opens the PR. This patch mirrors the queue-health parser behavior for the submission preflight path.Validation
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev python -m pytest tests/test_submission_quality_gate.py -q->24 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev python -m pytest -q->415 passed~/.local/bin/uv run --extra dev ruff check scripts/submission_quality_gate.py tests/test_submission_quality_gate.py-> passed~/.local/bin/uv run --extra dev ruff format --check scripts/submission_quality_gate.py tests/test_submission_quality_gate.py->2 files already formatted~/.local/bin/uv run --extra dev mypy app scripts/submission_quality_gate.py-> successgit diff --check-> cleanNote: pytest plugin autoload is disabled because this workstation has an unrelated ROS Humble pytest plugin on the global path.
Summary by CodeRabbit
New Features
\Normalize GitHub account lookup inputs #123`) in addition to plainNormalize GitHub account lookup inputs #123` format.Tests