Skip to content

Refs #406: Accept backticked bounty references#476

Open
er1c-cartman wants to merge 1 commit into
ramimbo:mainfrom
er1c-cartman:fix-406-backticked-bounty-ref
Open

Refs #406: Accept backticked bounty references#476
er1c-cartman wants to merge 1 commit into
ramimbo:mainfrom
er1c-cartman:fix-406-backticked-bounty-ref

Conversation

@er1c-cartman
Copy link
Copy Markdown

@er1c-cartman er1c-cartman commented May 26, 2026

Summary

  • allow pr_queue_health to recognize Markdown inline-code bounty references such as Refs `#406`
  • cover both prose references and /claim command bodies with a focused regression test

Refs #406.

Evidence

The current queue-health scanner recognizes Refs #406 and /claim #406, but it misses common Markdown inline-code variants such as Refs `#406` . That can incorrectly flag otherwise valid bounty PRs/comments as missing a bounty reference.

Validation

  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev python -m pytest tests/test_pr_queue_health.py -q -> 10 passed
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev python -m pytest -q -> 415 passed
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev ruff check scripts/pr_queue_health.py tests/test_pr_queue_health.py -> passed
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev ruff format --check scripts/pr_queue_health.py tests/test_pr_queue_health.py -> 2 files already formatted
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ~/.local/bin/uv run --extra dev python -m mypy app scripts/pr_queue_health.py -> success
  • git diff --check -> clean

Note: pytest plugin autoload is disabled because this workstation has an unrelated ROS Humble pytest plugin on the global path.

Summary by CodeRabbit

  • New Features
    • Enhanced bounty reference parsing to accept backticked reference numbers (e.g., #123), providing greater formatting flexibility when specifying bounty references in pull request titles and descriptions.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 00520975-aad2-4311-a2a8-8437f774bffd

📥 Commits

Reviewing files that changed from the base of the PR and between d8532d4 and 07d39cb.

📒 Files selected for processing (2)
  • scripts/pr_queue_health.py
  • tests/test_pr_queue_health.py

📝 Walkthrough

Walkthrough

Updated the bounty reference regular expression in the queue health analyzer to recognize backticks around issue numbers (e.g., `#310`). Added a test case verifying that backticked references are correctly parsed and do not trigger missing-reference warnings.

Changes

Backticked bounty reference recognition

Layer / File(s) Summary
Regex pattern and validation
scripts/pr_queue_health.py, tests/test_pr_queue_health.py
BOUNTY_REF_RE now accepts optional backticks around #<digits>. A new test verifies that analyze_queue recognizes backticked bounty references (e.g., Refs \#310`and/claim `#310``) as valid.

Possibly related PRs

  • ramimbo/mergework#324: Introduced initial pr_queue_health.py and analyze_queue functionality that this PR extends.
  • ramimbo/mergework#438: Prior modification to BOUNTY_REF_RE to recognize /claim prefixed references; this PR adds backtick support to that same regex.
🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Bounty Pr Focus ⚠️ Warning Commit adds 130 files (entire repo), not just the stated two files for Bounty #406 bounty reference regex fix and test. Rebase to isolate only the BOUNTY_REF_RE regex update and test changes from unrelated repo initialization files (configs, app, docs, migrations).
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Refs #406: Accept backticked bounty references' is concrete, names the changed surface, and accurately summarizes the main change.
Description check ✅ Passed The description covers the main summary, evidence of the issue, validation results, and references the related bounty. The template's Evidence section is addressed, though not all structured subsections are explicitly labeled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Mergework Public Artifact Hygiene ✅ Passed PR modifies bounty reference regex and adds test. README/docs state MRWK is native ledger with future snapshots/bridges subject to discussion, avoiding prohibited investment/price/cash-out claims.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@GHX5T-SOL GHX5T-SOL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head 07d39cb670c0557d4b754eb694804b92cccd869e.

No blocker found in this focused pass. The regex change is narrowly scoped to accepting optional backticks immediately around #<issue> after the existing bounty/ref/fix/close/claim prefixes, so existing plain references keep working while the common Markdown form is covered by regression tests.

Evidence checked:

  • PR is open, non-draft, mergeable/CLEAN, and project CI is successful.
  • CodeRabbit completed successfully with no actionable review comments.
  • gh pr diff --patch and the PR files API show only scripts/pr_queue_health.py and tests/test_pr_queue_health.py.
  • Existing /claim #310 coverage remains in the focused suite.
  • New regression coverage verifies both a backticked Refs reference and a backticked /claim reference produce no missing-bounty warning.

Validation:

  • uv run --extra dev python -m pytest tests/test_pr_queue_health.py -q -> 10 passed in 0.52s
  • uv run --extra dev python -m pytest -q -> 415 passed in 81.38s
  • uv run --extra dev python scripts/docs_smoke.py -> docs smoke ok
  • uv run --extra dev python -m mypy app scripts/pr_queue_health.py -> Success: no issues found in 31 source files
  • uv run --extra dev ruff check scripts/pr_queue_health.py tests/test_pr_queue_health.py -> All checks passed!
  • uv run --extra dev ruff format --check scripts/pr_queue_health.py tests/test_pr_queue_health.py -> 2 files already formatted
  • git diff --check origin/main...HEAD -> clean
  • git diff origin/main...HEAD | gitleaks stdin --no-banner --redact --exit-code 1 -> no leaks found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants