Open
Conversation
my first fork
Owner
|
I'm glad you found some use with the example! It's a great idea to get the edit form as a modal too. I have a couple of comments to make on your changes which I'll add as line comments on your pull request. |
Author
|
Btw, what would be the best way to attach the .modal click event on the articles soon after it is created? Right now, I'm guessing the event is only firing on older articles because it's wrapped in $(document).ready and the page needs to be refreshed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first fork/pull, not sure if I did it correctly. Thanks for the example! I made some changes so it uses modal if you press edit. It doesn't update the page asynchronously, it just updates and redirects to the articles_path.