Merged
Conversation
louise-davies
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1846 +/- ##
===========================================
+ Coverage 96.69% 96.71% +0.01%
===========================================
Files 219 219
Lines 30914 31042 +128
Branches 4624 4646 +22
===========================================
+ Hits 29893 30021 +128
+ Misses 1017 1016 -1
- Partials 4 5 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshdimanteto
approved these changes
Feb 24, 2026
Contributor
joshdimanteto
left a comment
joshdimanteto
left a comment
There was a problem hiding this comment.
LGTM. I made some changes to the commented out code for filtering null values in the publicationDate. Since the PR is now up on dg-api, this PR will require a small change to the CI because it branches off the “remove older Python version” PR. Specifically, Python 3.9 will need to be updated to Python 3.10.
Comment on lines
+177
to
+184
| // TODO: add back in when we can query for is not null | ||
| // { | ||
| // filterType: 'where', | ||
| // filterValue: JSON.stringify({ | ||
| // publicationDate: { neq: null }, | ||
| // }), | ||
| // }, | ||
| ] |
Contributor
There was a problem hiding this comment.
Suggested change
| // TODO: add back in when we can query for is not null | |
| // { | |
| // filterType: 'where', | |
| // filterValue: JSON.stringify({ | |
| // publicationDate: { neq: null }, | |
| // }), | |
| // }, | |
| ] | |
| // TODO: add back in when we can query for is not null | |
| // { | |
| // filterType: 'where', | |
| // filterValue: JSON.stringify({ | |
| // publicationDate: { isnull: false }, | |
| // }), | |
| // }, | |
| ] |
Comment on lines
+199
to
+205
| // TODO: add back in when we can query for is null | ||
| // { | ||
| // filterType: 'where', | ||
| // filterValue: JSON.stringify({ | ||
| // publicationDate: { eq: null }, | ||
| // }), | ||
| // }, |
Contributor
There was a problem hiding this comment.
Suggested change
| // TODO: add back in when we can query for is null | |
| // { | |
| // filterType: 'where', | |
| // filterValue: JSON.stringify({ | |
| // publicationDate: { eq: null }, | |
| // }), | |
| // }, | |
| // TODO: add back in when we can query for is null | |
| // { | |
| // filterType: 'where', | |
| // filterValue: JSON.stringify({ | |
| // publicationDate: { isnull: true }, | |
| // }), | |
| // }, |
Comment on lines
+319
to
+325
| // TODO: add back in when we can query for is not null | ||
| // { | ||
| // filterType: 'where', | ||
| // filterValue: JSON.stringify({ | ||
| // publicationDate: { neq: null }, | ||
| // }), | ||
| // }, |
Contributor
There was a problem hiding this comment.
Suggested change
| // TODO: add back in when we can query for is not null | |
| // { | |
| // filterType: 'where', | |
| // filterValue: JSON.stringify({ | |
| // publicationDate: { neq: null }, | |
| // }), | |
| // }, | |
| // TODO: add back in when we can query for is not null | |
| // { | |
| // filterType: 'where', | |
| // filterValue: JSON.stringify({ | |
| // publicationDate: { isnull: false }, | |
| // }), | |
| // }, |
Comment on lines
+335
to
+341
| // TODO: add back in when we can query for is null | ||
| // { | ||
| // filterType: 'where', | ||
| // filterValue: JSON.stringify({ | ||
| // publicationDate: { eq: null }, | ||
| // }), | ||
| // }, |
Contributor
There was a problem hiding this comment.
Suggested change
| // TODO: add back in when we can query for is null | |
| // { | |
| // filterType: 'where', | |
| // filterValue: JSON.stringify({ | |
| // publicationDate: { eq: null }, | |
| // }), | |
| // }, | |
| // TODO: add back in when we can query for is null | |
| // { | |
| // filterType: 'where', | |
| // filterValue: JSON.stringify({ | |
| // publicationDate: { isnull: true }, | |
| // }), | |
| // }, |
Member
Author
|
@joshdimanteto I just left the code in as "pseudo-code" to give the idea of what we want to do. I'll merge it in as is and it can be fixed when the PR on the API gets merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a "browse all datapublications" view so that open data users etc. can see all the DOIs that DLS will have.
Note that we currently have to separate out into user-defined and session DOIs in order to filter out versions. I will check with DLS whether they want to exclude versions and if they want to see all of them in a view together or whether separate is fine.
Also would like a open/closed data filter, but that code is commented out as datagateway-api doesn't support it yet. see ral-facilities/datagateway-api#527
Testing instructions
Add a set up instructions describing how the reviewer should test the code
/browse/datapublicationand see if you can see all the DOIs as an anon user