Move rdoc plugin permission fix into bootstrap ruby install step#192
Open
flavorjones wants to merge 1 commit intomainfrom
Open
Move rdoc plugin permission fix into bootstrap ruby install step#192flavorjones wants to merge 1 commit intomainfrom
flavorjones wants to merge 1 commit intomainfrom
Conversation
Resolve the TODO from #188 by moving the gem plugin permission fixup into the bootstrap ruby install RUN step, and remove the separate late-stage RUN layer that was added as a temporary workaround.
Collaborator
Author
|
Green, let's merge this before we ship v1.12.0 |
larskanis
reviewed
Mar 1, 2026
| done && \ | ||
| find ${RBENV_ROOT} -type d -print0 | sudo xargs -0 chmod g+w \ | ||
| find ${RBENV_ROOT} -type d -print0 | sudo xargs -0 chmod g+w && \ | ||
| find ${RBENV_ROOT} -path '*/plugins/*.rb' -print0 | sudo xargs -0 chmod g+w \ |
Member
There was a problem hiding this comment.
The only difference is that the permission of the directory isn't adjusted. I think it's not necessary, but to be sure I added gem-wrapper per commit 2db60b4 to the tests. Just to make sure new rubygem plugins install without permission error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chmod g+wfrom a late-stageRUNlayer into the bootstrap ruby install step, resolving the TODO added in Fixgem inst rdoc#188RUN sudo chmod go+w ... plugins -Rlayer that was a temporary workaroundCloses #191
Note
This changes an early Docker layer, so it will invalidate the layer cache for all subsequent steps. Do not merge until we're ready for the next minor version release.
Test plan
test_rdoc.rbpasses (gem inst rdocas mapped user succeeds)