ci: remove PR target Vercel preview workflow by findolor · Pull Request #2573 · rainlanguage/raindex

findolor · 2026-05-13T08:40:12Z

Related Issue

Fixes RAI-538

RAI-538: Remove PR target Vercel preview workflow

Motivation

The PR-target Vercel preview workflow is no longer needed. Removing it also eliminates the privileged pull_request_target path that checked out and built PR head code before using preview deployment secrets.

Solution

Delete the Vercel preview PR-target workflow.
Keep the existing internal branch Vercel preview workflow unchanged.

Checks

By submitting this for review, I confirm I have done the following:

made this PR as small as possible
unit-tested any new functionality
linked any relevant issues or PRs
included screenshots (if this involves a front-end change)

Additional validation run:

rg -n "pull_request_target" .github/workflows || true
git diff --check main...HEAD

Summary by CodeRabbit

Chores
- Removed the pull request preview deployment workflow for Vercel previews (the PR-target preview job and its gating).
- Simplified CI workflow set by eliminating the labeled preview deployment path and related approval gating.

coderabbitai · 2026-05-13T08:40:25Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2447be4e-feb6-4f41-8b57-2890be69134a

📥 Commits

Reviewing files that changed from the base of the PR and between 081468f and 5054ade.

📒 Files selected for processing (1)

.github/workflows/vercel-preview-pr-target.yaml

💤 Files with no reviewable changes (1)

.github/workflows/vercel-preview-pr-target.yaml

📝 Walkthrough

Walkthrough

A GitHub Actions workflow for PR-targeted Vercel preview deployments was removed. The deleted workflow used pull_request_target, label gating (vercel-preview), environment approval (vercel-preview), Nix build steps, npm blacklist checks, a pinned Vercel CLI install, Vercel preview deploy steps, and a Telegram fallback notifier.

Changes

Cohort / File(s)	Summary
GitHub Actions workflow `\.github/workflows/vercel-preview-pr-target.yaml`	File removed. Eliminates the `GitHub Actions Vercel Preview Deployment (PR Target)` workflow and its `Deploy-Preview-PR` job that used `pull_request_target` trigger, label gating, environment approval, Nix webapp builds, npm blacklist validation, pinned `vercel@51.8.0` CLI install, Vercel preview pull/deploy steps, and Telegram CI status forwarding on failure/cancel.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped along a CI trail,
and watched a workflow leave the vale.
No preview bells, no Vercel song,
the pipe slept quiet, soft, and long.
I twitched my nose — the tree feels hale. 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately describes the main change: removal of the PR target Vercel preview workflow. It is concise, specific, and directly reflects the changeset content.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch arda/remove-vercel-pr-target-preview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

linear · 2026-05-13T08:49:57Z

RAI-538

graphite-app · 2026-05-14T10:46:51Z

Merge activity

May 14, 10:46 AM UTC: findolor added this pull request to the Graphite merge queue.
May 14, 11:27 AM UTC: Merged by the Graphite merge queue.

## Related Issue Fixes RAI-538 - [RAI-538: Remove PR target Vercel preview workflow](https://linear.app/makeitrain/issue/RAI-538/remove-pr-target-vercel-preview-workflow) ## Motivation The PR-target Vercel preview workflow is no longer needed. Removing it also eliminates the privileged `pull_request_target` path that checked out and built PR head code before using preview deployment secrets. ## Solution - Delete the Vercel preview PR-target workflow. - Keep the existing internal branch Vercel preview workflow unchanged. ## Checks By submitting this for review, I confirm I have done the following: - [x] made this PR as small as possible - [ ] unit-tested any new functionality - [x] linked any relevant issues or PRs - [ ] included screenshots (if this involves a front-end change) Additional validation run: - `rg -n "pull_request_target" .github/workflows || true` - `git diff --check main...HEAD`  ## Summary by CodeRabbit * **Chores** * Removed pull request preview deployment workflow

github-actions · 2026-05-14T11:27:40Z

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

Simple bug fixes, typos, or minor refactoring
Single-purpose changes affecting 1-2 files
Documentation updates
Configuration tweaks
Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

Fix typo in variable name
Update README with new instructions
Adjust configuration values
Simple one-line bug fixes
Import statement cleanup

Medium (M)

Characteristics:

Feature additions or enhancements
Refactoring that touches multiple files but maintains existing behavior
Breaking changes with backward compatibility
Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

Add new feature or component
Refactor common utility functions
Update dependencies with minor breaking changes
Add new component with tests
Performance optimizations
More complex bug fixes

Large (L)

Characteristics:

Major feature implementations
Breaking changes or API redesigns
Complex refactoring across multiple modules
New architectural patterns or significant design changes
Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

Complete new feature with frontend/backend changes
Protocol upgrades or breaking changes
Major architectural refactoring
Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

Test coverage impact: More comprehensive test changes lean toward larger classification
Risk level: Changes to critical systems bump up a size category
Team familiarity: Novel patterns or technologies increase complexity

Notes:

the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
do not include any additional text, only the size classification
your assessment comment must not include tips or additional sections
do NOT tag me or anyone else on your comment

…aindex Resolves 37 conflicts: - UD deletes: dropped vercel-preview-pr-target.yaml (removed in #2573) and the leftover js_api/gui/{deposits,select_tokens}.rs (logic moved to common/raindex_order_builder/ via #2479). - UU code conflicts: kept the orderbook->raindex rename across crates, packages, and Solidity while taking in main's new functionality (multi-subgraph trades_list/trades_count, GUI->OrderBuilder rename, BaseRainterpreterSubParser->BaseRainlangSubParser, ContextProfile::Gui ->ContextProfile::Builder, get_orderbook_yaml->get_raindex_yaml, Orderbook::multicallCall->Raindex::multicallCall). - Lockfiles: Cargo.lock regenerated via cargo generate-lockfile; package-lock.json via npm install --package-lock-only. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

findolor self-assigned this May 13, 2026

findolor requested review from 0xgleb, JuaniRios and hardyjosh May 13, 2026 08:46

0xgleb approved these changes May 13, 2026

View reviewed changes

hardyjosh approved these changes May 14, 2026

View reviewed changes

graphite-app Bot force-pushed the arda/remove-vercel-pr-target-preview branch from 081468f to 5054ade Compare May 14, 2026 10:47

graphite-app Bot merged commit 5054ade into main May 14, 2026
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: remove PR target Vercel preview workflow#2573

ci: remove PR target Vercel preview workflow#2573
graphite-app[bot] merged 1 commit into
mainfrom
arda/remove-vercel-pr-target-preview

findolor commented May 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 13, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

linear Bot commented May 13, 2026

Uh oh!

graphite-app Bot commented May 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

findolor commented May 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue

Motivation

Solution

Checks

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

linear Bot commented May 13, 2026

Uh oh!

graphite-app Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

S/M/L PR Classification Guidelines:

Small (S)

Medium (M)

Large (L)

Additional Factors to Consider

Notes:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

findolor commented May 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 13, 2026 •

edited

Loading

graphite-app Bot commented May 14, 2026 •

edited

Loading